Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-namelist calculation of CLM dtime assumes NCPL_BASE_PERIOD=ndays #53

Open
billsacks opened this issue Dec 16, 2017 · 1 comment
Open
Labels
enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

Bill Sacks < sacks@ucar.edu > - 2017-01-16 10:21:20 -0700
Bugzilla Id: 2404
Bugzilla CC: lipscomb@lanl.gov, mvertens@ucar.edu, rfisher@ucar.edu,

From Bill Lipscomb:

In file …/clm/bld/CLMBuildNamelist.pm, l. 1917, the base period is hardwired to 3600 * 24. This means (if I understand correctly how dtime is computed) that if LND_NCPL is set to a large value (consistent with sub-daily atm coupling), I get a much shorter CLM time step than I want.

--

I agree with his assessment. Mariana is putting in a fix for a similar problem for mosart and rtm, but these are using some new shared python code. A similar fix is needed in CLM's perl-based build-namelist. It amounts to about 10 lines of code that need to be added to determine the basedt based on NCPL_BASE_PERIOD (I just don't remember what those 10 lines of code look like).

This is unlikely to affect users much: Bill Lipscomb was doing something unusual by changing NCPL_BASE_PERIOD. However, my understanding is that this will bite anyone who does change NCPL_BASE_PERIOD.

@billsacks billsacks added this to the clm5 milestone Dec 16, 2017
@billsacks
Copy link
Member Author

Erik Kluzek < erik@ucar.edu > - 2017-01-17 17:38:46 -0700

This will be fixed after the science freeze.

@billsacks billsacks added the enhancement new capability or improved behavior of existing capability label Feb 9, 2018
@billsacks billsacks removed this from the clm5 milestone Nov 7, 2018
jedwards4b added a commit to jedwards4b/ctsm that referenced this issue Jul 9, 2024
better fix for issue with ssh access
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jul 11, 2024
a60032499 Merge tag 'v0.8.2' into tmp-release
75a0337 Bump to 0.8.2
7136066 Merge pull request ESCOMP#54 from ESMCI/fix/tag-not-found
a90de4f update to fetch tag first
a6e43fc Bump to 0.8.1
229ba03 Merge pull request ESCOMP#53 from ESMCI/fix/ssh_access
e9cd2be better fix for issue with ssh access
c624b61 Bump to 0.8.0
6ccf617 Merge pull request ESCOMP#51 from ESMCI/fix/recursive
53fce57 no need to make submodule objects persist
dae1c82 now working with issue ESCOMP#50
ded91fd all tests passing, issue ESCOMP#50 fixed
62a338b all pytests now passing
143abac tests a-d all pass
2b021fd add documentation to submodule.py
72211d2 add the new submodule class
82dd7a4 test_b_update now working
a7d8b4e all pytests passing
5322019 Bump to 0.7.9
1f07cb6 Merge pull request ESCOMP#49 from ESMCI/fix/fxDONOTUSEurl
31ce71b use poetry update to update poetry.lock file
46043f0 add code of conduct (issue ESCOMP#35)
0c3d683 dependabot changes and issue ESCOMP#48
25ccc15de Merge tag 'v0.7.8' into tmp-release
8eae7e3 Bump to 0.7.8
34daa06 Merge pull request ESCOMP#46 from ESMCI/add_optional_keyword
af12c80 fix spelling
7ea36dc remove manage_externals error
2ede182 add optional to status output
4ff1e98de Merge tag 'v0.7.7' into tmp-release
87640ad Bump to 0.7.7
c124dc5 Merge pull request ESCOMP#43 from ESMCI/fix/root_dir
3ff935b update tests
0593149 one more improvement
d95f5d6 fix status issue
c304487 update complex test
a34070b Bump to 0.7.6
9e5d5f7 Merge pull request ESCOMP#40 from ESMCI/fix/change_url
00b7b38 some fixes when modifying url

git-subtree-dir: .lib/git-fleximod
git-subtree-split: a600324993623cba8e663fcbfdb6a0f6832dd802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

No branches or pull requests

1 participant