Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More confined regular expression for NEON #2044

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Jun 28, 2023

Description of changes

More confined regular expression for NEON. And a few simple fixes.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #2039
Fixes #2103
Fixes #2028
Fixes #1506
Fixes #1499

Are answers expected to change (and if so in what way)? Yes? For some NEON cases?

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: None so far, but regular testing will be run

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations labels Jun 28, 2023
@ekluzek ekluzek self-assigned this Jun 28, 2023
@wwieder
Copy link
Contributor

wwieder commented Aug 2, 2023

@ekluzek I wonder what a timeline for merging this change could be? I ask because @danicalombardozzi is working on revisions to our NEON paper and assumed that we'll also need @briandobbins to make a new docker image with the code modifications that have evolved since our last NEON branch tag?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Aug 2, 2023

Hi Will. Let's talk more tomorrow. But, we've been delaying on this to get other work in. And we want the BGC sequencing work to come in as soon as it's ready so difficult merges won't have to happen. This is simple enough and orthogonal to that, that it's going to be OK to come in before that if needed. I think we should be able to get it in sometime next week.

FATES API update to facilitate fates refactor

This updates a number of FATES type names and module use statements
which correspond with a refactoring effort that moves FATES
patches and cohorts into their own respective modules.

With the FATES update is a minor science update, so there are
changes to answers for FATES.

This also incorporates a minor update to a more recent version
of the ccs config external.
…SRDAT rather than \$CLM_USRDAT_NAME as it is now
…aving res be CLM_USRDAT when clm_usr_name option is set and setting fsurdat and flanduse in namelist defaults for NEON sites
@wwieder
Copy link
Contributor

wwieder commented Nov 14, 2023

@slevis-lmwg can you add this to the merge tag you're working on, it addressed a bug we need fixed for the container used for NEON runs.

@wwieder
Copy link
Contributor

wwieder commented Nov 14, 2023

The testing isn't as critical, but the updates to shell commands is the bug fix I'd like to bring in.
cime_config/usermods_dirs/NEON/defaults/shell_commands

@slevis-lmwg slevis-lmwg merged commit ed728bf into ESCOMP:master Nov 15, 2023
2 checks passed
@slevis-lmwg slevis-lmwg deleted the compset_fix branch November 15, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
No open projects
3 participants