Fix long names for RH2M_R, AZSUN, and update nofates and fates history variable lists in User's Guide

[olyson]

Description of changes

Fix the long names for history variables for RH2M_R and AZSUN. Update nofates and fates history variable lists in User's Guide.

Specific notes

Note that the nofates and fates history variable lists contain other updates than just RH2M_R and AZSUN, as it appears these haven't been updated recently. In particular, the updates to the fates list are substantial.

Contributors other than yourself, if any: @cathyxinchangli

CTSM Issues Fixed (include github issue #): Issues #2511 , #2506

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

[samsrabin]

Looks good, Keith. What sort of testing have you done? I'm pretty sure long_name changes shouldn't trigger diffs from baseline, but it'd be good to make sure.

[olyson]

clm_short testing is in progress. I was going to try to build the documentation but docker isn't working on my laptop and I need ISG help to install/update.

[olyson]

clm_short tests pass. Except for MEMCOMP tests which fail due to missing cpl-mem.log in ctsm5.1.001 baselines. I assume this is not a problem

[samsrabin]

Good that ctsm_short works! Looking back at the procedure, it does specify that the entire aux_clm suite should be run. However, I think that's probably overkill here—the only lines changed in the code are the long_name specifications.

[olyson]

I was going to perform the rest of the procedure, e.g., beginning with step 1, once I had the prerequisite completed which was to have an approved PR. My b4bdev branch is now behind since you just committed a new version. So I imagine I should do steps 1-6 now.

[samsrabin]

Ah okay good point! Carry on then :-)

[olyson]

If I understand the process correctly, I guess I should wait for PR #2514 to complete, which merges master back into b4b-dev.

[olyson]

Ok, steps 1-6 have been completed. aux_clm testing passes as expected. I don't have permissions to do step 7.

[ekluzek]

@olyson I think you should be given those permissions. Are you good with me adding your capability to merge to b4b-dev?

[olyson]

Sure, thanks.

[ekluzek]

@olyson I invited you to the ctsm-b4b-dev team. Did you get that invite? Once you accept you should be able to push the green merge button.

[olyson]

Hmm, I don't see the invite. I assume it comes via email.

[ekluzek]

@olyson I checked and there was a permission issue I needed to fix. And you now are in the ctsm-b4bdev group (you must have accepted the email invite and maybe didn't notice).

So try again and hopefully it works now. It should also work for @TeaganKing now as well.

[TeaganKing]

Ah, yes, I do see that I can merge PRs now.

[olyson]

Yes, thanks, just merged now.