Fix RXCROPMATURITY test #2599
Merged
Fix RXCROPMATURITY test #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for troubleshooting: * RXCROPMATURITYSKIPRUN skips the build and run phases. * RXCROPMATURITYSKIPBUILD just skips the build phase. It still does the run phase so as to test everything before actual run submission.
samsrabin
force-pushed
the
fix-rxcropmaturity
branch
3 times, most recently
from
b018060
to
72f1194
Compare
Also adds rxcropmaturity test suite with that and a coarse version of the existing RXCROPMATURITY test. So: * RXCROPMATURITY_Lm61.f10_f10_mg37.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput * RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput
samsrabin
force-pushed
the
fix-rxcropmaturity
branch
from
bbce00e
to
3efa49a
Compare
ekluzek
requested changes
Jun 18, 2024
There was a problem hiding this comment.
This is great. I love that you are not only fixing the issue, but also bringing in some new testing that is likely to catch issues sooner.
There's a few questions I have, and some changes I ask for. One is potentially bigger if it does make sense, but that could be done by opening an issue and working on it later.
If it would be beneficial to meet, that's also something we could do.
ekluzek
reviewed
Jun 19, 2024
ekluzek
approved these changes
Jun 19, 2024
Merged
slevis-lmwg
added a commit
to slevis-lmwg/ctsm
that referenced
this pull request
Jun 21, 2024
…20240620 Merge b4bdev 20240620 Fix long names ESCOMP#2512 Dust emissions moved to Object Oriented design ESCOMP#2552 Fix RXCROPMATURITY test ESCOMP#2599 NB: This will be the first tag in branch tmp-240620 in a series of temporary tags while we wait for the completion of the beta01 cesm tag.
ekluzek
added a commit
to ekluzek/CTSM
that referenced
this pull request
Jun 21, 2024
…ximod Merge b4bdev 20240620 Fix long names ESCOMP#2512 Dust emissions moved to Object Oriented design ESCOMP#2552 Fix RXCROPMATURITY test ESCOMP#2599 NB: This will be the first tag in branch tmp-240620 in a series of temporary tags while we wait for the completion of the beta01 cesm tag. Conflicts: doc/ChangeLog doc/ChangeSum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Copies a file from one case directory to another, fixing the RXCROPMATURITY test. Also adds a shorter version of that, RXCROPMATURITYSKIPGEN, which is useful for testing. It's short enough that I've added it as a new test in
aux_clm, so now we have some coverage of the RXCROPMATURITY stuff.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
pylint, which complains about a file I didn't touch.aux_clmtest passes (RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput).ctsm_scitest in progress (RXCROPMATURITY_Lm61.f09_g17.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput).RXCROPMATURITY_Lm61.f10_f10_mg37.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput).