Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fan 2019 ctsm #767

Draft
wants to merge 209 commits into
base: master
Choose a base branch
from
Draft

Fan 2019 ctsm #767

wants to merge 209 commits into from

Conversation

juliusvira
Copy link

@juliusvira juliusvira commented Jul 24, 2019 •
edited
Loading

Description of changes

Includes the FANv2 (Flow of Agricultural Nitrogen) process model for simulating ammonia volatilization from fertilizers and manure.

Specific notes

Are answers expected to change (and if so in what way)?

Connecting FAN to the CLM biogeochemistry (nitrogen pools) can be toggled from namelist. If not connected, answers should not change. If connected, C and N cycling will change.

Any User Interface Changes (namelist or namelist defaults changes)?

Added FAN namelist with some options and path to the FAN stream file.

Testing performed, if any:

The model has been tested with a 3-year (2009-2011) transient run for the following:

  • C and N related variables do not change if FAN is off or not coupled to the biogeochemistry
  • FAN produces NH3 emissions as expected
  • Running with biogeochemistry coupling enabled works technically and conserves N.
    Scientific evaluation of the biogeochemistry coupling is to be done.

Other remarks:

  • FAN has the capability to move N from crop to soil column within a grid cell, depending on the fract_spread_grass namelist variable.
  • The N balance check currently essentially checks separately for N conservation in FAN and in the rest of CLM. The advantage is that this works the same way regardless of whether FAN is coupled to the biogeochemistry or not. The drawback is that mass conservation between FAN and CLM is not checked. There could be a few ways to fix this.

Edit: link to slides comparing various FAN coupling options:
https://drive.google.com/file/d/1CROPPXphlwhWCMbLKl_RKUaaSehUomHg/view?usp=sharing

jv388 added 30 commits March 15, 2018 10:07
@bjandre
FAN_n05_clm4_5_18_r272
01c1153 
created the n05 tag
Merge remote-tracking branch 'remotes/escomp/release-clm5.0' into fan…
2b6b2a8 
…-clm5
point externals to fancpl branch
5127039
first attempt, not quite working
e23d599
add handling of -fan option to CLMBuildNamelist
f52f159
Merge branch 'master' into fan-clm5-cpl (fix LND_TUNING_MODE)
36c6d1a
FAN NH3 to coupler
f94ac48
finally correct units for manure nitrogen
63df80b
output name NH3_total -> NH3_TOTAL
6c5185e
non-negativity checks tweaked
0227fd3
manure unit conversion again
cc8c864
nh->nf
f4b7cbb
remove uninitilized fert_to_soil + increase bogus n_stored limit acco…
def5ee8 
…rding to the correct unit
Handle size 1 tan pools correctly
f591e8d
debugging: disarray between crop pheno and ndep, lower wtgcell thresh…
c65ecf6 
…old for skipping
fix zeroing the fluxes
6b256ba
other-fert output
e20a808
change to fancpl2 cime
138e09a
fanstream attempt 1
b71f54b
variable fert fractions (2)
59478df
mods from the summer 2018 experiments (1)
44333c9
drydep mods, clm side
0910db2
Merge branch 'drydep-mods' of https://github.com/juliusvira/ctsm into…
2b4ba5b 
… fan-clm5-cpl-poolmods
cleanup
bb2dc1e
fix tan_fract + mass check
761bb11
fix typo
9292097
increased housing/storage emissions
d744560
version without drydep mods
5b9473a
output field for manure in barns
feba86d
Merge branch 'fan-clm5-cpl-poolmods' into fan-clm5-cpl-poolmods-nodd
772a6ba
ekluzek added 21 commits September 8, 2022 22:59
@ekluzek
Merge tag 'ctsm5.1.dev108' into fan-2019-ctsm
cdee600 
Connect ozone from atmosphere

Allow atmospheric input of ozone partial pressure (monthly, mol/mol) to
CTSM and use this ozone in the OzoneMod module.

Specific notes: Add ozone to atm2lndType and also add as an output
history variable (ATM_O3). Read in O3 in lnd_import_export. Connect to
the OzoneMod module: in CalcOzoneUptakeOnePoint we now use this input
ozone, rather than a static parameter.

 Conflicts:
	Externals.cfg
	bld/unit_testers/build-namelist_test.pl
	cime_config/testdefs/ExpectedTestFails.xml
	cime_config/testdefs/testlist_clm.xml
	src/biogeochem/CNBalanceCheckMod.F90
	src/biogeochem/CNNDynamicsMod.F90
	src/biogeochem/CNVegNitrogenFluxType.F90
	src/main/clm_driver.F90
	src/main/lnd2atmMod.F90
	src/main/lnd2atmType.F90
	src/soilbiogeochem/SoilBiogeochemNitrogenStateType.F90
@ekluzek
Use new get_curr_days_per_year in FAN streams which is required in th…
86bb9a4 
…e update
@ekluzek
Move shr_fan from share to cmeps, so change so share is standard, and…
43cc324 
… cmeps is a branch
@ekluzek
Add path for lilac to shr_fan_mod.F90 under cmeps so that LILAC can b…
aa4d65b 
…uild
@ekluzek
Add an update to cmeps
521686c
@ekluzek
Add passing of FAN fields to atm Fall_FANflxnh3 for NUOPC case
9b6a56d
@ekluzek
Add code to handle reading in the FAN streams for nuopc
ee8ef31
@ekluzek
Add a default NUOPC version of each of the FAN MCT tests
7ea2c77
@ekluzek
Add a test for a NEON AG site with FAN on
757baa0
@ekluzek
Get to compile on nag compiler on izumi
63be0ed
@ekluzek
Make KONA test case a BGC-CROP compset and add a I1PT BGC-CROP compset
0fe26fc
@ekluzek
Mark FAN NUOPC threaded test as an expected fail
136d23f
@ekluzek
Update cmeps externals with changes needed for FAN
d08dbd9
@ekluzek
Set FAN meshfile and make name consistent with new CMEPS
90f5e39
@ekluzek
Merge branch 'fan-2019-ctsm' of github.com:juliusvira/ctsm into fan-2…
613c8bf 
…019-ctsm
@ekluzek
Update cpl7 so shr_fan_mod is included
22e0add
@ekluzek
Merge branch 'fan-2019-ctsm' of github.com:juliusvira/ctsm into fan-2…
02526e5 
…019-ctsm
@ekluzek
Add dummy_mesh argument, because it's required for the NUOPC interfac…
020704c 
…e, internally it can be ignored
@ekluzek
Add shr_assert to check array size, and switch to loops over array co…
625c225 
…pies, as well as properly adjusting g index by begg
@ekluzek
Change izumi_nag non debug tests to izumi_intel for FAN since DEBUG t…
84f9ca3 
…ests fail for nag
@ekluzek
Add a stub ROF Hist Clm51 Bgc-Crop compset
326bd8c
@wwieder
Copy link
Contributor

wwieder commented Nov 15, 2022

@ekluzek now that you've created a branch tag for this PR, does it remain open?

@ekluzek
Copy link
Collaborator

ekluzek commented Nov 15, 2022

I think we leave it open as a reminder that we eventually want to bring it into main CTSM. But as we have plenty of open PRs we could close it for now. Let's talk about this Thursday.

@ekluzek ekluzek removed this from the ctsm5.2.0 milestone Apr 20, 2024
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science and removed enh - new science labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwieder wwieder wwieder left review comments

@billsacks billsacks billsacks requested changes

@ekluzek ekluzek Awaiting requested review from ekluzek

@negin513 negin513 Awaiting requested review from negin513

Requested changes must be addressed to merge this pull request.

Assignees

@wwieder wwieder

@ekluzek ekluzek

Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
CTSM-CLM6 development highlights
Status: Prep line - not close to the oven
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusvira @ekluzek @wwieder @billsacks @samsrabin