Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fan 2019 ctsm #767

Draft
wants to merge 209 commits into
base: master
Choose a base branch
from

Add a stub ROF Hist Clm51 Bgc-Crop compset

326bd8c
Select commit
Loading
Failed to load commit list.
Draft

Fan 2019 ctsm #767

Add a stub ROF Hist Clm51 Bgc-Crop compset
326bd8c
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2025-02-05 04:52:12 ago

0 / 4 tasks completed

4 tasks still to be completed

Details

Required Tasks

Task Status
C and N related variables do not change if FAN is off or not coupled to the biogeochemistry Incomplete
FAN produces NH3 emissions as expected Incomplete
Running with biogeochemistry coupling enabled works technically and conserves N.
Scientific evaluation of the biogeochemistry coupling is to be done. Incomplete
FAN has the capability to move N from crop to soil column within a grid cell, depending on the fract_spread_grass namelist variable. Incomplete
The N balance check currently essentially checks separately for N conservation in FAN and in the rest of CLM. The advantage is that this works the same way regardless of whether FAN is coupled to the biogeochemistry or not. The drawback is that mass conservation between FAN and CLM is not checked. There could be a few ways to fix this. Incomplete
FERT_N_APP = NFERTILIZATION mapped to columns Incomplete
MAN_N_BARNS in crop columns Incomplete
MAN_N_GRZ in native veg. columns.
The total manure production is always MAN_N_BARNS + MAN_N_GRZ on grid cell level and also on column level if fract_spread_grass is 0. If fract_spread_grass > 0, it gets more complicated since some of MAN_N_BARNS is rerouted to the native column. Incomplete
MAN_N_TOTAL = MAN_N_BARNS + MAN_N_GRZ Incomplete
MAN_N_TO_SMINN = MANURE_NH4_TO_SOIL+MANURE_NO3_PROD Incomplete
SYNTHFERT_N_TO_SMINN = FERT_NH4_TO_SOIL + FERT_NO3_PROD
or whatever names sound good. Incomplete
NFERTILIZATION should always be the sum of manure and synthetic fertilizer inputs Incomplete
With FANoff this should be unchanged, the sum of parameter file manure and streams N inputs, Note, this is a patch level calculation Incomplete
With FANon we have two manure inputs being used. One from the parameter file that's still being passed to crops and a second that is being read in from FAN's dataset and ONLY used to calculate HN3 emissions and NO3 leaching. What manure do we add to NFERTILIZATION here, it seems we should just keep track of the one that crops actually see? Incomplete
With FANbgc this would be NFERTILIZATION = MANURE_N_TOTAL + SYNTHFERT_N_TOTAL
This is a column level calculation Incomplete
NFERTILIZATION_TO_SMINN = MANURE_N_TO_SMINN + SYNTHFERT_N_TO_SMINN
These would only be turned on for FANbgc simulations AND/OR
Could be defined differently
NFERTILIZATION_TO_SMINN = NFERTILIZATION
For FANoff or FANon simulations (and not connected to soilBGC)
As with NFERTILIZATION, this should be calculated this in the fan_to_sminn subroutine of Fan2CTSMMod.F90 Incomplete
A minor suggestion would be to write out MANURE (as MAN is confusing for other model users)
MANURE_N_TOTAL = MANURE_N_BARNS + MANURE_N_GRZ
MANURE_N_TO_SMINN = MANURE_NH4_TO_SOIL+MANURE_NO3_TO_SOIL
SYNTHFERT_N_TO_SMINN = SYNTHFERT_NH4_TO_SOIL + SYNTHFERT_NO3_TO_SOIL Incomplete
Last detail. Why the distinction between _NH4_TO_SOIL vs. _NO3_PROD in your comment @juliusvira ? Is the assumption currently applied that all the NO3 losses from FAN interact with the soil matrix, or are some of these LEACHED terms supposed to go straight to runoff and the rivers? It seems these _SMINN fluxes should just be the fraction that's going to the soil BGC?
SYNTHFERT_N_TO_SMINN = SYNTHFERT_NH4_TO_SOIL + SYNTHFERT_NO3_TO_SOIL
in other words, does SYNTHFERT_NO3_TO_SOIL == SYNTHFERT_NO3_PROD? Incomplete
MANURE_N_TOTAL = MAN_N_BARNS + MAN_N_GRZ
whenever fan is on Incomplete
NFERTILIZATION is the N that be would go to the soil mineral pools in absence of losses:
NFERTILIZATION = NSYNTHFERT+NMANURE (fan off or not coupled to bgc)
NFERTILIZATION = MANURE_N_BARNS+FERT_N_APP (in fanbgc-crop if fract_spread_grass = 0)
NFERTILIZATION = MANURE_N_TOTAL+FERT_N_APP (in fanbgc-full)
where FERT_N_APP = NSYNTHFERT, but only created when fan is on. Incomplete
MANURE_N_TO_SMINN and SYNTHFERT_N_TO_SMINN are the FAN fluxes to the soil N pools after losses; ie. SYNTHFERT_N_TO_SMINN = FERT_NH4_TO_SOIL + FERT_NO3_TO_SOIL and similar for manure. If the bgc coupling is not active ("fanon") then these are zero. Incomplete
@ekluzek this isn't a priority for CESM2.2 of PPE tags, but I think it should be included in the CTSM5.1 release. Incomplete
@juliusvira one thing we'll need is a description from you for the technical note. There's a bunch of documentation on how to do this at the bottom of the wiki page (like this). Incomplete
There are a handful of items still marked with a check box, I'll go through and see if these are resolved. Incomplete