devel:devel+classic #94
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were lost when erigon dropped the external erigon-lib dep, copy-pasting it to a package under this project root. Date: 2023-10-09 15:32:11-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2023-10-10 07:28:48-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Conflicts: core/blockchain.go
Historically we had several times when: - erigon downloaded new version of .seg file - or didn't finish download and start indexing this was a "quick-fix protection" against this cases but now we have other protections for this cases let's try to remove this one - because it's not compatible with "copy datadir" and "restore datadir from backup" scenarios
Conflicts: erigon-lib/chain/chain_config.go erigon-lib/chain/networkname/network_name_classic.go go.sum
Date: 2023-10-25 05:57:03-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…on/common/hexutil Date: 2023-10-25 05:58:30-06:00 Signed-off-by: meows <b5c6@protonmail.com>
erigontech#8580) PR erigontech#8202 might cause Issue erigontech#8550, so reverting it until Alexey's return. This reverts commit 2ce98f8.
…h#8499) Bor consensus: this calc is heavy and has cache
Newly introduced `t.logGaps` was being set to `nil` and still accessed within `clearFailedLogs`. This PR changes the ordering, moving the nil setting to `CaptureTxEnd`.
* call getEnode before NodeStarted to make sure it is ready for RPC calls * fix connection error detection on macOS * use a non-default p2p port to avoid conflicts * disable bor milestones on local heimdall * generate node keys for static peers config
```
error: conflicting types for ‘mdbx_get_datacmp’ due to enum/integer mismatch; have ‘int (*(unsigned int))(const MDBX_val *, const MDBX_val *)’ {aka ‘int (*(unsigned int))(const struct iovec *, const struct iovec *)’} [-Werror=enum-int-mismatch]
26609 | __cold MDBX_cmp_func *mdbx_get_datacmp(unsigned flags) {
| ^~~~~~~~~~~~~~~~
mdbx.h:4932:1: note: previous declaration of ‘mdbx_get_datacmp’ with type ‘int (*(MDBX_db_flags_t))(const MDBX_val *, const MDBX_val *)’ {aka ‘int (*(MDBX_db_flags_t))(const struct iovec *, const struct iovec *)’}
```
can't upgrade mdbx version for now
|
This PR is stale because it has been open for 40 days with no activity. |
|
This PR is stale because it has been open for 40 days with no activity. |
|
This PR is stale because it has been open for 40 days with no activity. |
|
This PR is stale because it has been open for 40 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to present the diff for visibility and review.
The base branch
develis upstream's main branch.The target branch is our patch branch that establishes support for ETC.
This PR should not be merged!