Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delay to Tooltips (use shadcn) #153

Closed
SoulKa opened this issue Dec 11, 2024 · 2 comments · Fixed by #183
Closed

Add Delay to Tooltips (use shadcn) #153

SoulKa opened this issue Dec 11, 2024 · 2 comments · Fixed by #183
Assignees
Labels
enhancement New feature or request frontend Frontend related task good first issue Good for newcomers
Milestone

Comments

@SoulKa
Copy link
Collaborator

SoulKa commented Dec 11, 2024

The current tooltip implementation instantly shows the tooltip. In the sidebar, this can be irritation for the user. Instead, a delay should be used to show the tooltip. The shadcn tooltop component already supports this.

Acceptance Criteria

@SoulKa SoulKa added enhancement New feature or request frontend Frontend related task labels Dec 11, 2024
@SoulKa SoulKa added this to the v0.2 milestone Dec 11, 2024
@giemic8 giemic8 added the good first issue Good for newcomers label Dec 16, 2024
@meminger
Copy link
Contributor

@SoulKa @giemic8 Hey! Would love to take this on if it's still up for grabs!
Just wanted to check - should all tooltips have this delay, or just the sidebar one? Do you have a specific delay in mind?

@SoulKa
Copy link
Collaborator Author

SoulKa commented Jan 17, 2025

Hi @meminger, welcome to the project :) Currently, the delay should only be added to the sidebar items, since it's quite irritating when selecting a request. We don't have a specific delay set, maybe 500ms-1s? I think it's easiest to test a good value once the delay is implemented.
The other tooltips in the application don't need a delay, but they should still be switched over to the new shadcn tooltip component to have a consistent code base.

Happy coding!

meminger added a commit to meminger/trufos that referenced this issue Jan 18, 2025
meminger added a commit to meminger/trufos that referenced this issue Jan 18, 2025
…response status to add consistent delay and improve tooltip behavior
meminger added a commit to meminger/trufos that referenced this issue Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Frontend related task good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants