Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/153 shadcn tooltip integration #183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

meminger
Copy link

@meminger meminger commented Jan 18, 2025

Changes

  • Resolves Add Delay to Tooltips (use shadcn) #153
  • Add shadcn tooltip component to improve tooltip functionality and accessibility
  • Replace CSS-based tooltips with shadcn tooltip (with 750ms delay) component in:
    • Sidebar request list
    • Response status component
  • This change improves tooltip consistency and adds better accessibility features

Testing

Manual testing performed:

  • Verified tooltip functionality in sidebar with 750ms delay
  • Confirmed tooltip works in response status component
  • Tested hover behavior and content display

Sidebar Tooltip

trufos-sidebar-tooltip

Response Status Tooltip

trufos-response-status-tooltip

Checklist

  • Issue has been linked to this PR
  • Code has been reviewed by person creating the PR
  • Commit messages, branch names, code formatting adheres to our Contributing Guidelines
  • Automated tests have been written, if possible
  • Manual testing has been performed
  • Documentation has been updated, if necessary
  • Changes have been reviewed by second person

…response status to add consistent delay and improve tooltip behavior
Copy link
Collaborator

@SoulKa SoulKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! Got only a small changes suggestion to centralize the tooltip provider.

<span>Body: {getSizeText(metaInfo.size.bodySizeInBytes)}</span>
</div>
</span>
<TooltipProvider>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add the provider to application root in App.tsx? We would only need a single one for the whole application then.

From the docs:

Wraps your app to provide global functionality to your tooltips.

@SoulKa SoulKa self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Delay to Tooltips (use shadcn)
2 participants