Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted SDK and update requirements and references #673

Closed
wants to merge 12 commits into from

Conversation

imagobea
Copy link
Contributor

@imagobea imagobea commented May 24, 2022

TODO

  • Confirm solution for package.json: Sourcing a private repository from a different org requires using a GitHub Personal Access Token (this was the most straight fw solution, there's also SSH). This has been signalled by referencing an ENV var THAT NEEDS TO BE REPLACED MANUALLY (get in touch for the token). The result is that gral public won't be able to clone and run nightfall_3 in the meantime. > Change nightfall-sdk visibility to public

  • Check GitHub actions after updating repo visibility 🐞 - pipelines fail >> npm/cli issue #2610, there's a link to a temp solution which suggests to limit npm vs to 6

  • Check what to do w/package.json script re sdk > Will (should) live in the SDK repo, relates to:

{
  "name": "cli",
  "version": "1.0.0",
  "description": "A command line interface for Nightfall_3",
  "main": "build/index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "build": "babel lib -d build"
  },
  "dependencies": {}
}

In nightfall_3/cli/package.json.

  • README, is CLI still alive?
  • Check private repo nf3 dependencies before deleting sdk from here

@imagobea imagobea added the SDK To be reflected on the SDK repo label May 25, 2022
@imagobea imagobea closed this May 27, 2022
@imagobea imagobea deleted the bea/rm-sdk-update-reqs-and-refs branch June 10, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDK To be reflected on the SDK repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant