This repository has been archived by the owner on Dec 22, 2022. It is now read-only.
Pack Nightfall SDK #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druiz0992
reviewed
May 25, 2022
| clientApiUrl: 'https://client1.testnet.nightfall3.com', | ||
| optimistApiUrl: 'https://optimist1.testnet.nightfall3.com', | ||
| optimistWsUrl: 'wss://optimist1-ws.testnet.nightfall3.com', | ||
| web3WsUrl: 'wss://ropsten1-ws.testnet.nightfall3.com', |
There was a problem hiding this comment.
This is one of the things we need to think about. web3 cannot be passed like this because its private.
druiz0992
approved these changes
May 25, 2022
imagobea
force-pushed
the
bea/pack-nightfall-sdk
branch
from
9f3d171 to
9c8df11
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
This PR is the first step towards extracting and publishing
nightfall-sdk"v1".Requires also updates on the nightfall public repo, but let's merge here first to have a working version on master ASAP.
Changes:
Ported files from nightfall public repo
Check this commit for differences re
nf3.jsfile (this is about logger - 11 instances have been replaced simply withconsolefor now)Added package.json. We have some time to think about some of the fields till we publish the NPM package, e.g.:
@maticnetwork/nightfall-sdkscope, as other repos doLet me know if this is enough as a first step. Cheers!