Dinspec implementation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d implementations in -2 and -20 on both secc and evcc sides.
tropxy
requested changes
Mar 26, 2022
Comment on lines
17
to
56
| V2G_SECC_READYTOCHARGE_PERFORMANCE_TIME = 148 | ||
| V2G_EVCC_READYTOCHARGE_TIMEOUT = 150 | ||
| V2G_SECC_COMMUNICATIONSETUP_PERFORMANCE_TIME = 18 | ||
| V2G_EVCC_COMMUNICATIONSETUP_TIMEOUT = 20 | ||
| V2G_SECC_CABLE_CHECK_PERFORMANCE_TIME = 38 | ||
| V2G_EVCC_CABLE_CHECK_TIMEOUT = 40 | ||
| V2G_SECC_PRE_CHARGE_PERFORMANCE_TIME = 5 | ||
| V2G_EVCC_PRE_CHARGE_TIMEOUT = 7 | ||
| V2G_SECC_CPState_Detection_Timeout = 1.5 | ||
| V2G_SECC_CPOscillator_Retain_time = 1.5 | ||
|
|
||
| # Message specific timings | ||
| # Refer section 9.6.2 (Table 75) | ||
| SUPPORTED_APP_PROTOCOL_REQ = 2 | ||
| SESSION_SETUP_REQ = 2 | ||
| SERVICE_DISCOVERY_REQ = 2 | ||
| SERVICE_PAYMENT_SELECTION_REQ = 2 | ||
| CONTRACT_AUTHENTICATION_REQ = 2 | ||
| CHARGE_PARAMETER_DISCOVERY_REQ = 2 | ||
| POWER_DELIVERY_REQ = 2 | ||
| CABLE_CHECK_REQ = 2 | ||
| PRE_CHARGE_REQ = 2 | ||
| CURRENT_DEMAND_REQ = 0.25 | ||
| WELDING_DETECTION_REQ = 2 | ||
| SESSION_STOP_REQ = 2 | ||
| SUPPORTED_APP_PROTOCOL_RES = 1.5 | ||
| SESSION_SETUP_RES = 1.5 | ||
| SERVICE_DISCOVERY_RES = 1.5 | ||
| SERVICE_PAYMENT_SELECTION_RES = 1.5 | ||
| CONTRACT_AUTHENTICATION_RES = 1.5 | ||
| CHARGE_PARAMETER_DISCOVERY_RES = 1.5 | ||
| POWER_DELIVERY_RES = 1.5 | ||
| CABLE_CHECK_RES = 1.5 | ||
| PRE_CHARGE_RES = 1.5 | ||
| CURRENT_DEMAND_RES = 0.025 | ||
| WELDING_DETECTION_RES = 1.5 | ||
| SESSION_STOP_RES = 1.5 | ||
|
|
||
| V2G_SECC_SEQUENCE_TIMEOUT = 60 | ||
| V2G_EVCC_SEQUENCE_PERFORMANCE_TIME = 59 |
There was a problem hiding this comment.
we dont need the performance timers...we are only interested in the timeouts.
it is also a bit counter intuitive, but when we enter into an EVCC state, we already sent a Req, so then we are waiting for the Res and therefore there is a Timeout. In the spec they associate the timeout to the Req, like CHARGE_PARAMETER_DISCOVERY_REQ i.e., the EVCC has sent the CHARGE_PARAMETER_DISCOVERY_REQ message and is waiting for the Response. In my perspective the timeout should be called one of this options:
- EVCC_CHARGE_PARAMETER_DISCOVERY
- CHARGE_PARAMETER_DISCOVERY_RES
but not CHARGE_PARAMETER_DISCOVERY_REQ
There was a problem hiding this comment.
Hmm...I see you mean the timeout is actually associated with the upcoming response message and so should indicate that. Instead of saying - this request that I just sent has a timeout value of x_req before receiving a response.
I feel it is a matter of perspective and the convention is to have it from the request's perspecitve. For instance lost ping message would say request timed out?
… set to false (AB#1439) Also, Major version for DIN SPEC is 2 (in supportedAppProtocolReq).
…lection to ServicePaymentSelection
* ability to add existing EVSEController * Separate config validataion in order to have another way to configure iso15118 * Added some some abstract methods for DC-Charging * Completed State CableCheck. But is not tested * Added State Precharge * Implemented CableCheck in EVCC states. Reached State Precharge with EVCC/EVSE simulation * simulatin with SECC/EVCC works until beginning of CurrentDemand * simulatin with SECC/EVCC works until beginning of CurrentDemand * Simulation with SECC/EVCC reaches CurrentDemand and is constantly sending CurrendDemandReq/Res * Just Layout changes and some comments. No changes in productive Code * First sucessfull unittest * wip DC_state current_demand and pytests * DC-States until Welding-Detection. * Added some pytests * added timeouts for CableCheck and Precharge * some changes in interface * implemented feedback from André * review from Shalin * improvements #2 from Pullrequest * improvements # from Pullrequest * improvements #4 from pullrequest * reformat code to fullfill black and flake8 * Decreased the number of Precharge cycles to avoid the Timeout. Reformated a few error messages around the code * Reformated the Exi Codec class creation as its former use complicated testing; fixed the tests * reformated the code * fixed flake8 issues * Revert "Reformated the Exi Codec class creation as its former use complicated testing; fixed the tests" This reverts commit 1b6e798. * fixed bugs inserted after the git reverse * fixed the tests by patching the to_exi method * flaked 8 the code * marked tests as async for future compatability and added mode on the pytest init config as specified here: https://github.com/pytest-dev/pytest-asyncio\#modes * added conftest * fixed flake eror Co-authored-by: Martin Bachmann <martin.bachmann@designwerk.com> Co-authored-by: tropxy <andre14x@gmail.com>
tropxy
requested changes
Apr 2, 2022
…d implementations in -2 and -20 on both secc and evcc sides.
… set to false (AB#1439) Also, Major version for DIN SPEC is 2 (in supportedAppProtocolReq).
…lection to ServicePaymentSelection
…iso15118 into dinspec_implementation
…ests., Also added timeout check to WeldingDetectionRes in -2
tropxy
reviewed
Apr 11, 2022
tropxy
requested changes
Apr 11, 2022
…messages/datatypes. Fixed dinspec related mypy issues.
tropxy
previously approved these changes
Apr 12, 2022
tropxy
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checkin DIN SPEC implementation. Added support for states until ChargeParameterDiscoveryReq.