Fix of the several messages that misuse the List type #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
force-pushed
the
fix_messages_datatypes
branch
from
c0c1163 to
08857fd
Compare
tropxy
force-pushed
the
fix_messages_datatypes
branch
from
6a198d5 to
f0e9a50
Compare
tropxy
force-pushed
the
fix_messages_datatypes
branch
from
f0e9a50 to
dd3e726
Compare
…e EMAID type for the same Message
…t object to a dict
… of ProfileEntry to a ProfileEntry object containing a list of ProfileEntryDetails
…lasses over the different custom exception classes
…nature creation in CertificateInstallationRes; created constrained type eMAID
… algorithm entries and a few questions
…also refactored failed_responses.py
tropxy
force-pushed
the
fix_messages_datatypes
branch
from
e5022d2 to
045f7ac
Compare
MarcMueltin
suggested changes
Dec 31, 2021
…ings regarding the signature method
MarcMueltin
suggested changes
Jan 4, 2022
MarcMueltin
approved these changes
Jan 4, 2022
tropxy
added a commit
that referenced
this pull request
Apr 1, 2022
* ability to add existing EVSEController * Separate config validataion in order to have another way to configure iso15118 * Added some some abstract methods for DC-Charging * Completed State CableCheck. But is not tested * Added State Precharge * Implemented CableCheck in EVCC states. Reached State Precharge with EVCC/EVSE simulation * simulatin with SECC/EVCC works until beginning of CurrentDemand * simulatin with SECC/EVCC works until beginning of CurrentDemand * Simulation with SECC/EVCC reaches CurrentDemand and is constantly sending CurrendDemandReq/Res * Just Layout changes and some comments. No changes in productive Code * First sucessfull unittest * wip DC_state current_demand and pytests * DC-States until Welding-Detection. * Added some pytests * added timeouts for CableCheck and Precharge * some changes in interface * implemented feedback from André * review from Shalin * improvements #2 from Pullrequest * improvements # from Pullrequest * improvements #4 from pullrequest * reformat code to fullfill black and flake8 * Decreased the number of Precharge cycles to avoid the Timeout. Reformated a few error messages around the code * Reformated the Exi Codec class creation as its former use complicated testing; fixed the tests * reformated the code * fixed flake8 issues * Revert "Reformated the Exi Codec class creation as its former use complicated testing; fixed the tests" This reverts commit 1b6e798. * fixed bugs inserted after the git reverse * fixed the tests by patching the to_exi method * flaked 8 the code * marked tests as async for future compatability and added mode on the pytest init config as specified here: https://github.com/pytest-dev/pytest-asyncio\#modes * added conftest * fixed flake eror Co-authored-by: Martin Bachmann <martin.bachmann@designwerk.com> Co-authored-by: tropxy <andre14x@gmail.com>
tropxy
added a commit
that referenced
this pull request
Apr 12, 2022
* Updated branch to use jar with DINSpec support * Updated timeout values for DINSpec. Minor formatting to stop black from complaining. * Added reference schema files. * DIN SPEC schema representation - first draft * Updated din_spec/datatypes.py * Updated comm_session.py and exi_codec to accept DINSPEC message types. * Updated abstract method definition in states.py and updated associated implementations in -2 and -20 on both secc and evcc sides. * Setting preferred protocol to DIN SPEC on evcc side for now (to be changed later.) * Fixed flake8 and black errors. Removed message types not used by DINSpec. * Fixed flake8 and black errors. Moved EnergyTransferMode to common enums. * Initial checkin - DIN SPEC states for EVCC and SECC. * Code format mods to pass tests on GitHub. * Support for remaining states till SessionStop * Refactoring to move common classes between -2 dc and dinspec messages. * Updated EXICodec.jar with fix for WeldingDetectionRes message (#27) * feat: Addressed some of the comments on PR(AB#1439) * feat: DIN SPEC should not be listed in supported protocols if use_tls set to false (AB#1439) Also, Major version for DIN SPEC is 2 (in supportedAppProtocolReq). * feat: Add timeout handling to CableCheck, renamed ServiceAndPaymentSelection to ServicePaymentSelection * feat: Added tests. Fixed identified issue with CableCheck. * Feature/dc states till session stop (#21) * ability to add existing EVSEController * Separate config validataion in order to have another way to configure iso15118 * Added some some abstract methods for DC-Charging * Completed State CableCheck. But is not tested * Added State Precharge * Implemented CableCheck in EVCC states. Reached State Precharge with EVCC/EVSE simulation * simulatin with SECC/EVCC works until beginning of CurrentDemand * simulatin with SECC/EVCC works until beginning of CurrentDemand * Simulation with SECC/EVCC reaches CurrentDemand and is constantly sending CurrendDemandReq/Res * Just Layout changes and some comments. No changes in productive Code * First sucessfull unittest * wip DC_state current_demand and pytests * DC-States until Welding-Detection. * Added some pytests * added timeouts for CableCheck and Precharge * some changes in interface * implemented feedback from André * review from Shalin * improvements #2 from Pullrequest * improvements # from Pullrequest * improvements #4 from pullrequest * reformat code to fullfill black and flake8 * Decreased the number of Precharge cycles to avoid the Timeout. Reformated a few error messages around the code * Reformated the Exi Codec class creation as its former use complicated testing; fixed the tests * reformated the code * fixed flake8 issues * Revert "Reformated the Exi Codec class creation as its former use complicated testing; fixed the tests" This reverts commit 1b6e798. * fixed bugs inserted after the git reverse * fixed the tests by patching the to_exi method * flaked 8 the code * marked tests as async for future compatability and added mode on the pytest init config as specified here: https://github.com/pytest-dev/pytest-asyncio\#modes * added conftest * fixed flake eror Co-authored-by: Martin Bachmann <martin.bachmann@designwerk.com> Co-authored-by: tropxy <andre14x@gmail.com> * feat: More fixes. (AB#1439) * Updated timeout values for DINSpec. Minor formatting to stop black from complaining. * Added reference schema files. * DIN SPEC schema representation - first draft * Updated din_spec/datatypes.py * Updated comm_session.py and exi_codec to accept DINSPEC message types. * Updated abstract method definition in states.py and updated associated implementations in -2 and -20 on both secc and evcc sides. * Setting preferred protocol to DIN SPEC on evcc side for now (to be changed later.) * Fixed flake8 and black errors. Removed message types not used by DINSpec. * Fixed flake8 and black errors. Moved EnergyTransferMode to common enums. * Initial checkin - DIN SPEC states for EVCC and SECC. * Code format mods to pass tests on GitHub. * Support for remaining states till SessionStop * Refactoring to move common classes between -2 dc and dinspec messages. * feat: Addressed some of the comments on PR(AB#1439) * feat: DIN SPEC should not be listed in supported protocols if use_tls set to false (AB#1439) Also, Major version for DIN SPEC is 2 (in supportedAppProtocolReq). * feat: Add timeout handling to CableCheck, renamed ServiceAndPaymentSelection to ServicePaymentSelection * feat: Added tests. Fixed identified issue with CableCheck. * feat: More fixes. (AB#1439) * feat: Rebased to master. Re-added missed (AB#1439) * feat: Updated failing tests(AB#1439) * feat: Addressed comments in PR (AB#1439) * feat: Fixed failing tests(AB#1439) * feat: added timeout checkj to CableCheck, WeldingDetection, updated tests., Also added timeout check to WeldingDetectionRes in -2 * feat: Addressed comments on PR. Added missing docstrings.(AB#1439) * feat: Addressed comments on PR(AB#1439) * feat: Renamed shared/messages/datatypes_iso15118_2_dinspec to shared/messages/datatypes. Fixed dinspec related mypy issues. * feat: Fixed flake8 errors * feat: Updated tests following file rename (AB#1439) Co-authored-by: lukaslombriserdesignwerk <95468282+lukaslombriserdesignwerk@users.noreply.github.com> Co-authored-by: Martin Bachmann <martin.bachmann@designwerk.com> Co-authored-by: tropxy <andre14x@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.