This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
fix: refactor search page structure #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
small
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
|
Reviewpad Report ℹ️ Messages
|
remove results if under 3 characters
github-actions
bot
added
the
medium
schmelto
commented
Nov 10, 2022
Comment on lines
+83
to
+87
| {!threeOrMore && ( | ||
| <h2 className="bg-yellow-200 text-yellow-600 border-2 border-yellow-600 p-5 my-5 text-xl"> | ||
| You have to enter at least 3 characters to search for a user. | ||
| </h2> | ||
| )} |
There was a problem hiding this comment.
This is something we should discuss if this is more suitable as the text in the search box
There was a problem hiding this comment.
we could also move the alert to a separate component in another PR, maybe it accepts a type of alert (info, warning, error)
eddiejaoude
approved these changes
Nov 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
user not found under the search bar.
Old:
This change prevents that the search bar is jumping on the page when the error message appears
Further added a warning message if the search string is less than 3 characters
Remove the results list if the search string is less than 3 characters