Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: refactor search page structure #2196

Merged
merged 2 commits into from
Nov 11, 2022
Merged

fix: refactor search page structure #2196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf7273
fix: refactor page structure
schmelto Nov 10, 2022
e0dc420
feat: add warning
schmelto Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions pages/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,27 @@ export default function Search({ users }) {
const { username } = router.query;
const [filteredUsers, setFilteredUsers] = useState([]);
const [notFound, setNotFound] = useState();
const [threeOrMore, setThreeOrMore] = useState();

let results = [];

useEffect(() => {
if (username) {
setNotFound(username);
setThreeOrMore(false);
}
}, []);

const filterData = (value) => {
if (value.length <= 3) {
setThreeOrMore(false);
setFilteredUsers(results);
setNotFound();
}

if (value.length >= 3) {
const results = users.filter((user) =>
setThreeOrMore(true);
results = users.filter((user) =>
user.name.toLowerCase().includes(value.toLowerCase())
);

Expand All @@ -61,18 +68,23 @@ export default function Search({ users }) {
<link rel="icon" href="/favicon.ico" />
</Head>
<div className="flex flex-col px-6 align-center">
{notFound && (
<h2 className="bg-red-200 text-red-600 border-2 border-red-600 p-5 my-5 text-xl">
{notFound} not found
</h2>
)}
<h1 className="text-4xl mb-4 font-bold">Search</h1>
<input
placeholder="Search users (minimum 3 characters)"
placeholder="Search users"
className="border-2 hover:border-orange-600 transition-all duration-250 ease-linear rounded px-6 py-2"
name="keyword"
onChange={(e) => filterData(e.target.value)}
/>
{notFound && (
<h2 className="bg-red-200 text-red-600 border-2 border-red-600 p-5 my-5 text-xl">
{notFound} not found
</h2>
)}
{!threeOrMore && (
<h2 className="bg-yellow-200 text-yellow-600 border-2 border-yellow-600 p-5 my-5 text-xl">
You have to enter at least 3 characters to search for a user.
</h2>
)}
Comment on lines +83 to +87
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we should discuss if this is more suitable as the text in the search box

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also move the alert to a separate component in another PR, maybe it accepts a type of alert (info, warning, error)

<ul>
{filteredUsers.map((user) => (
<li key={user.username}>
Expand Down