Make major upgrade to styled HOC #5762
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/styled-components-upgrade
branch
from
d3bd20a to
7f558c6
Compare
Jon-edge
approved these changes
Sep 30, 2025
Jon-edge
approved these changes
Sep 30, 2025
| * ``` | ||
| * | ||
| * @deprecated Use `cacheStyles` for styles, or if there really is a needed | ||
| * abstraction, create a new full component (but think about it atleast three |
There was a problem hiding this comment.
More concise for new component barriers is if it: "helps readability" or "is reused at least once"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Marks
styledHOC as deprecated, recommendingcacheStylesor creating a full component instead.Written by Cursor Bugbot for commit 7f558c6. This will update automatically on new commits. Configure here.