Skip to content

Make major upgrade to styled HOC #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −0
Open

Make major upgrade to styled HOC #5762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/hoc/styled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ type Styler<Props> =
* const Dynamic = styled(Text)(theme => props => ({ color: props.color ?? theme.color }))
* const DynamicSansTheme = styled(Text)(_theme => props => ({ color: props.color }))
* ```
*
* @deprecated Use `cacheStyles` for styles, or if there really is a needed
* abstraction, create a new full component (but think about it atleast three
Copy link
Collaborator

@Jon-edge Jon-edge Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More concise for new component barriers is if it: "helps readability" or "is reused at least once"

* times before you do).
*/
export function styled<BaseProps extends StyleProps>(
Component: React.ComponentType<BaseProps>
Expand Down
Loading