Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds map to the office world. #69

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Aug 1, 2024

🎉 New feature

Closes #67

Test it

ros2 launch andino_gz andino_gz.launch.py nav2:=True world_name:=office.sdf map:=office

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone requested a review from Voldivh August 1, 2024 06:02
@Voldivh
Copy link
Collaborator

Voldivh commented Aug 1, 2024

@francocipollone I tried it out and it looks fine, however, I noticed this error appearing all the time:
Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist [rviz2-5] at line 93 in ./src/buffer_core.cpp

Voldivh
Voldivh previously approved these changes Aug 1, 2024
@francocipollone
Copy link
Collaborator Author

@francocipollone I tried it out and it looks fine, however, I noticed this error appearing all the time: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist [rviz2-5] at line 93 in ./src/buffer_core.cpp

Does it happen after sending the initial pose?

@Voldivh
Copy link
Collaborator

Voldivh commented Aug 1, 2024

@francocipollone I tried it out and it looks fine, however, I noticed this error appearing all the time: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist [rviz2-5] at line 93 in ./src/buffer_core.cpp

Does it happen after sending the initial pose?

Which command should I use for that? Call the set_initial_pose service?

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@Voldivh
Copy link
Collaborator

Voldivh commented Aug 8, 2024

LGTM!

@francocipollone francocipollone merged commit 41b523a into humble Aug 8, 2024
2 checks passed
@francocipollone francocipollone deleted the francocipollone/office_map_file branch August 8, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add map for the office.sdf world
2 participants