Merge pull request #3851 from lawli3t/improve-tests-keymeta

Add additional test cases for module keymeta

doc/api_review/core/keyCopyAllMeta.md

@@ -85,8 +85,8 @@
 
 - [x] Function code is fully covered by tests
 - [ ] All possible error states are covered by tests  
-       - [ ] add test for dest NULL  
-       - [ ] add test for source NULL
+       - [x] add test for dest NULL  
+       - [x] add test for source NULL
 - All possible enum values are covered by tests
 - [x] No inconsistencies between tests and documentation
 

doc/api_review/core/keyCurrentMeta.md

@@ -86,7 +86,7 @@
 
 - [x] Function code is fully covered by tests
 - [ ] All possible error states are covered by tests  
-       - [ ] add check for null pointer
+       - [x] add check for null pointer
 - All possible enum values are covered by tests
 - [x] No inconsistencies between tests and documentation
 

doc/api_review/core/keyGetMeta.md

@@ -93,10 +93,10 @@
 ### Tests
 
 - [ ] Function code is fully covered by tests  
-       - [ ] see below
+       - [x] see below
 - [ ] All possible error states are covered by tests  
-       - [ ] key is 0  
-       - [ ] metaName is 0
+       - [x] key is 0  
+       - [x] metaName is 0
 - All possible enum values are covered by tests
 - [x] No inconsistencies between tests and documentation
 

doc/api_review/core/keyMeta.md

@@ -86,9 +86,9 @@
 
 - [x] Function code is fully covered by tests
 - [ ] All possible error states are covered by tests  
-       - [ ] add check if key is NULL  
-       - [ ] add check if key has no metadata  
-       - [ ] add test if metadata is read-only
+       - [x] add check if key is NULL  
+       - [x] add check if key has no metadata  
+       - [x] add test if metadata is read-only
 - All possible enum values are covered by tests
 - [ ] No inconsistencies between tests and documentation
 

doc/api_review/core/keyNextMeta.md

@@ -83,7 +83,7 @@
 
 - [x] Function code is fully covered by tests
 - [ ] All possible error states are covered by tests  
-       - [ ] add check for NULL pointer
+       - [x] add check for NULL pointer
 - All possible enum values are covered by tests
 - [x] No inconsistencies between tests and documentation
 

doc/api_review/core/keyRewindMeta.md

@@ -89,7 +89,7 @@
 
 - [x] Function code is fully covered by tests
 - [ ] All possible error states are covered by tests  
-       - [ ] add test for null pointer
+       - [x] add test for null pointer
 - All possible enum values are covered by tests
 - [x] No inconsistencies between tests and documentation
 

doc/api_review/core/keySetMeta.md

@@ -92,13 +92,13 @@
 ### Tests
 
 - [x] Function code is fully covered by tests  
-       - [ ] memory errors hard to cover
+       - [x] memory errors hard to cover
 - [ ] All possible error states are covered by tests  
-       - [ ] memory errors hard to cover
+       - [x] memory errors hard to cover
 - All possible enum values are covered by tests
 - [ ] No inconsistencies between tests and documentation  
-       - [ ] test case for key 0  
-       - [ ] test case for name 0  
+       - [x] test case for key 0  
+       - [x] test case for name 0  
        - [ ] test case for invalid name
 
 ## Summary

doc/news/_preparation_next_release.md

@@ -237,6 +237,7 @@ _(Michael Tucek)_
 - Use clang-format 12 for Restyled and update Restyled version. _(Mihael Pranjić)_
 - Update all Restyled formatters to current versions. _(Mihael Pranjić)_
 - Add additional test cases for module `keytest` _(@lawli3t)_
+- Add additional test cases for module `keymeta` _(@lawli3t)_
 - <<TODO>>
 - <<TODO>>
 

src/libs/elektra/keymeta.c

@@ -241,7 +241,7 @@ const Key * keyCurrentMeta (const Key * key)
  * Do a shallow copy of metadata with name @p metaName from source to dest.
  *
  * Afterwards @p source and @p dest will have the same metadata referred with
- * @p metaName. If the Key with name @p metaName doesn't exist in @p src -
+ * @p metaName. If the Key with name @p metaName doesn't exist in @p source -
  * it gets deleted in @p dest.
  *
  * For example the metadata type is copied into the

tests/abi/testabi_meta.c

@@ -59,6 +59,34 @@ static void test_basic (void)
 	keyDel (key);
 }
 
+static void test_null_pointer (void)
+{
+	Key * key;
+
+	key = keyNew ("user:/test1", KEY_END);
+	exit_if_fail (key, "could not create new key");
+
+	succeed_if (keyRewindMeta (0) == -1, "Could rewind NULL Key");
+
+	succeed_if (keyGetMeta (0, "test") == 0, "Could get meta of NULL Key");
+	succeed_if (keyGetMeta (key, 0) == 0, "Could get meta of NULL metaName");
+
+	succeed_if (keyMeta (0) == 0, "Could get metadata of NULL Key");
+	succeed_if (keyCurrentMeta (0) == 0, "Could get current meta Key of NULL key");
+	succeed_if (keyNextMeta (0) == 0, "Could get next meta Key of NULL key");
+
+	succeed_if (keyCopyMeta (0, key, "test") == -1, "Could copy metadata to NULL Key");
+	succeed_if (keyCopyMeta (key, 0, "test") == -1, "Could copy metadata from NULL Key");
+
+	succeed_if (keyCopyAllMeta (0, key) == -1, "Could copy all metadata to NULL Key");
+	succeed_if (keyCopyAllMeta (key, 0) == -1, "Could copy all metadata from NULL Key");
+
+	succeed_if (keySetMeta (0, "test", "test"), "Could set metadata to NULL Key");
+	succeed_if (keySetMeta (key, 0, "test"), "Could set metadata with NULL metaName");
+
+	keyDel (key);
+}
+
 static void test_iterate (void)
 {
 	Key * key;
@@ -594,6 +622,7 @@ int main (int argc, char ** argv)
 	init (argc, argv);
 
 	test_basic ();
+	test_null_pointer ();
 	test_iterate ();
 	test_size ();
 	test_dup ();