-
Notifications
You must be signed in to change notification settings - Fork 123
Add additional test cases for module keymeta #3851
Add additional test cases for module keymeta #3851
Conversation
df55f80
to
0281a14
Compare
Can you please rebase? |
… that fixes the underlying bug
257faf8
to
bae4e2e
Compare
should be good now! |
@robaerd seems like the build job hangs in SSH copy. Can you maybe set some timeout? See https://build.libelektra.org/blue/organizations/jenkins/libelektra/detail/PR-3851/9/pipeline |
This comment has been minimized.
This comment has been minimized.
Doesn't seem stuck to me. The ssh upload step just takes a lot of time. However, 10 minutes just for the ssh upload is definitely too slow. |
The Jenkins job was still not finished after 2 days? Or did someone restart the job in between?
If the ssh upload took only 10 minutes then the problem was probably somewhere else (btw. I aborted the job, how did you see how long it took?). If the problem really was the transfer: something like rsync would be ideal. Btw. In general it is always good if the build server jobs try to redo things if they might fail on network problems. |
This comment has been minimized.
This comment has been minimized.
According to the logs the build job was triggered by the branch indexing trigger and started on 20.09 at 12:50. Maybe you mistook the currently running job for the previous one that was triggered on 16.09 by a commit?
You can check the duration of each step + stage in the Blue Ocean UI or get the overall timing info from the classic UI. |
jenkins build libelektra please |
LGTM now! 🚀 |
Thank you so much! |
Basics
These points need to be fulfilled for every PR:
(added as entry in
doc/news/_preparation_next_release.md
whichcontains
_(my name)_
)Please always add something to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.
Checklist
Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.
(not in the PR description)
Review
Reviewers will usually check the following:
Labels
If you are already Elektra developer:
say that everything is ready to be merged.