Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add additional test cases for module keymeta #3851

Merged
merged 5 commits into from
Sep 26, 2021

Conversation

lawli3t
Copy link
Contributor

@lawli3t lawli3t commented May 13, 2021

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

tests/abi/testabi_meta.c Outdated Show resolved Hide resolved
@markus2330
Copy link
Contributor

Can you please rebase?

@lawli3t lawli3t force-pushed the improve-tests-keymeta branch from 257faf8 to bae4e2e Compare September 16, 2021 17:00
@lawli3t
Copy link
Contributor Author

lawli3t commented Sep 18, 2021

should be good now!

@markus2330
Copy link
Contributor

@robaerd seems like the build job hangs in SSH copy. Can you maybe set some timeout? See https://build.libelektra.org/blue/organizations/jenkins/libelektra/detail/PR-3851/9/pipeline

@markus2330

This comment has been minimized.

@robaerd
Copy link
Member

robaerd commented Sep 20, 2021

@robaerd seems like the build job hangs in SSH copy. Can you maybe set some timeout?

Doesn't seem stuck to me. The ssh upload step just takes a lot of time. However, 10 minutes just for the ssh upload is definitely too slow.
A solution for this would be to replace the upload step in which every file is uploaded individually, by creating a tarball of the doc directories, uploading it and extracting it at the destination.
If you want, I could create a PR for this.

@markus2330
Copy link
Contributor

Doesn't seem stuck to me. The ssh upload step just takes a lot of time. However, 10 minutes just for the ssh upload is definitely too slow.

The Jenkins job was still not finished after 2 days? Or did someone restart the job in between?

A solution for this would be to replace the upload step in which every file is uploaded individually, by creating a tarball of the doc directories, uploading it and extracting it at the destination.
If you want, I could create a PR for this.

If the ssh upload took only 10 minutes then the problem was probably somewhere else (btw. I aborted the job, how did you see how long it took?).

If the problem really was the transfer: something like rsync would be ideal.

Btw. In general it is always good if the build server jobs try to redo things if they might fail on network problems.

@markus2330

This comment has been minimized.

@robaerd
Copy link
Member

robaerd commented Sep 23, 2021

The Jenkins job was still not finished after 2 days? Or did someone restart the job in between?

According to the logs the build job was triggered by the branch indexing trigger and started on 20.09 at 12:50. Maybe you mistook the currently running job for the previous one that was triggered on 16.09 by a commit?

... (btw. I aborted the job, how did you see how long it took?).

You can check the duration of each step + stage in the Blue Ocean UI or get the overall timing info from the classic UI.

@lawli3t
Copy link
Contributor Author

lawli3t commented Sep 25, 2021

jenkins build libelektra please

@lawli3t
Copy link
Contributor Author

lawli3t commented Sep 25, 2021

LGTM now! 🚀

@mpranj mpranj added this to the 0.9.8 milestone Sep 26, 2021
@mpranj mpranj merged commit 28bbf3e into ElektraInitiative:master Sep 26, 2021
@mpranj
Copy link
Member

mpranj commented Sep 26, 2021

Thank you so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants