Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsmtool: generatehsm does not generate a valid hsm_secret (anymore?) #4302

Closed
darosior opened this issue Jan 2, 2021 · 0 comments · Fixed by #4304
Closed

hsmtool: generatehsm does not generate a valid hsm_secret (anymore?) #4302

darosior opened this issue Jan 2, 2021 · 0 comments · Fixed by #4304

Comments

@darosior
Copy link
Collaborator

darosior commented Jan 2, 2021

Didn't tackle it down yet, noticed it while working on #4186 . See the comment on the original PR #4065 (comment)
darosior added a commit to darosior/lightning that referenced this issue Jan 2, 2021
@darosior
pytest: reproduce issue ElementsProject#4302
06dc111 
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
darosior added a commit to darosior/lightning that referenced this issue Jan 2, 2021
@darosior
hsmtool: only write 32 bytes to hsm_secret on generatehsm
fb87b67 
Fixes ElementsProject#4302
Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
darosior added a commit to darosior/lightning that referenced this issue Jan 2, 2021
@darosior
hsmtool: only write 32 bytes to hsm_secret on generatehsm
9591be5 
Fixes ElementsProject#4302
Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
@darosior darosior mentioned this issue Jan 3, 2021
Merged
darosior added a commit to darosior/lightning that referenced this issue Jan 4, 2021
@darosior
pytest: reproduce issue ElementsProject#4302
a1b1dd3 
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
darosior added a commit to darosior/lightning that referenced this issue Jan 4, 2021
@darosior
hsmtool: only write 32 bytes to hsm_secret on generatehsm
6455c90 
Fixes ElementsProject#4302
Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
cdecker pushed a commit to darosior/lightning that referenced this issue Jan 4, 2021
@darosior @cdecker
pytest: reproduce issue ElementsProject#4302
5fb5595 
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
cdecker pushed a commit to darosior/lightning that referenced this issue Jan 4, 2021
@darosior @cdecker
hsmtool: only write 32 bytes to hsm_secret on generatehsm
dbbcc27 
Fixes ElementsProject#4302
Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
cdecker pushed a commit that referenced this issue Jan 4, 2021
@darosior @cdecker
pytest: reproduce issue #4302
aa2586a 
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
cdecker pushed a commit that referenced this issue Jan 4, 2021
@darosior @cdecker
hsmtool: only write 32 bytes to hsm_secret on generatehsm
19afe15 
Fixes #4302
Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
vibhaa pushed a commit to spider-pcn/lightning that referenced this issue Mar 24, 2021
@darosior @vibhaa
pytest: reproduce issue ElementsProject#4302
e500f11 
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
vibhaa pushed a commit to spider-pcn/lightning that referenced this issue Mar 24, 2021
@darosior @vibhaa
hsmtool: only write 32 bytes to hsm_secret on generatehsm
593cd50 
Fixes ElementsProject#4302
Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hsmtool: fix hsm_secret generation darosior/lightning
1 participant
@darosior