hsmtool: fix hsm_secret generation #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
fix_generatehsm
branch
from
9591be5
to
6455c90
Compare
cdecker
approved these changes
Jan 4, 2021
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Fixes ElementsProject#4302 Changelog-fixed: hsmtool: the `generatehsm` command now generates an appropriately-sized hsm_secret Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
cdecker
force-pushed
the
fix_generatehsm
branch
from
6455c90
to
dbbcc27
Compare
jsarenik
reviewed
Mar 9, 2021
| @@ -530,7 +532,9 @@ static int generate_hsm(const char *hsm_secret_path) | |||
| if (fd < 0) { | |||
| errx(ERROR_USAGE, "Unable to create hsm_secret file"); | |||
| } | |||
| if (!write_all(fd, bip32_seed, bip32_seed_len)) | |||
| /* Write only the first 32 bytes, length of the (plaintext) seed in the | |||
|
It was meant by opposition to 'ciphertext'
…-------- Original Message --------
On Mar 9, 2021, 11:28, Ján Sáreník wrote:
@jsarenik commented on this pull request.
Sorry I noticed just now, but the hsm_secret contains 32 bytes of binary, not plaintext.
---------------------------------------------------------------
In [tools/hsmtool.c](#4304 (comment)):
> @@ -530,7 +532,9 @@ static int generate_hsm(const char *hsm_secret_path)
if (fd < 0) {
errx(ERROR_USAGE, "Unable to create hsm_secret file");
}
- if (!write_all(fd, bip32_seed, bip32_seed_len))
+ /* Write only the first 32 bytes, length of the (plaintext) seed in the
plaintext?
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#4304 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F363MUOAXVVZYCGDLTTCXZ5HANCNFSM4VRNUEBQ).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4284 , fixes #4302 .