Reproduce pay route crash #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
reproduce-pay-route-crash
branch
from
cc2324b
to
8a8f595
Compare
|
Rebase on master, which contains the fix this tests. |
|
seems like you've got some whitespace issues in the python and a timing issue. lgtm otherwise. |
rustyrussell
force-pushed
the
reproduce-pay-route-crash
branch
3 times, most recently
from
1e8d77f
to
bd61291
Compare
|
Trivial rebase |
This makes testing easier, and makes sense: lightningd might not *know* about other connected channels, depending on gossip, but if the user specifies it we should obey it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON: `invoice` `exposeprivatechannels` now includes explicitly named channels even if they seem like dead-ends.
When route returns a result which is too expensive, we try to figure out which hop is most expensive to exclude it for next time. If it's a single-hop route, we don't count it, since the first hop is free. That's not usually a problem, since single-hop routes can't exceed our limits (they're always "free"!). But if we are using a routehint, the total cost could exceed our limits, even if the start of the routehint is a single hop away. This reproduces that test case. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
reproduce-pay-route-crash
branch
from
bd61291
to
79c5e0a
Compare
|
... and added Changelog into commit msg for deadend heuristic and expostprivatechannels. |
|
ACK 79c5e0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduces the crash in #3607 which @niftynei fixed in #3630