Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproduce pay route crash #3633

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Reproduce pay route crash #3633

merged 2 commits into from
Apr 14, 2020

Commits on Apr 14, 2020

  1. invoice: ignore dead-end heuristic on explicitly specified channels. 

    This makes testing easier, and makes sense: lightningd might not
*know* about other connected channels, depending on gossip, but if the
user specifies it we should obey it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: JSON: `invoice` `exposeprivatechannels` now includes explicitly named channels even if they seem like dead-ends.
    @rustyrussell
    rustyrussell committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    6e58eb8 View commit details
    Browse the repository at this point in the history

  2. pytest: test for pay adjacent routehint crash. 

    When route returns a result which is too expensive, we try to figure out which
hop is most expensive to exclude it for next time.

If it's a single-hop route, we don't count it, since the first hop is free.
That's not usually a problem, since single-hop routes can't exceed our limits
(they're always "free"!).

But if we are using a routehint, the total cost could exceed our limits,
even if the start of the routehint is a single hop away.

This reproduces that test case.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    79c5e0a View commit details
    Browse the repository at this point in the history