Plugin: shutdown notification #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a legacy from when it didn't have an ld pointer to access ld's timer structure. Now it's just confusing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Not necessary yet, but it will be once shutdown starts waiting for plugins to respond: we don't want these to try to access the bcli plugin once it's freed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
plugin-shutdown-notification
branch
from
212b90b
to
1e3d90b
Compare
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Plugins: `shutdown` notification for clean exits.
We weren't actually getting the last log out; this does that. We have to fix test_bitcoin_failure which now notices the BROKEN log message. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: libplugin: Fatal error messages from plugin_exit() now logged in lightningd.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
plugin-shutdown-notification
branch
from
1e3d90b
to
4106888
Compare
|
ACK 4106888 Change looks good, but I was expecting this to be a hook so the plugin could return a list of memory leaks as a result. Will look at the followup before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @cdecker . A followup PR uses this in developer mode to do leak detection.