Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: shutdown notification #4754

Merged
merged 6 commits into from
Sep 5, 2021
Merged

Plugin: shutdown notification #4754

merged 6 commits into from
Sep 5, 2021

Commits on Sep 1, 2021

  1. lightningd: don't keep timer ptr inside struct chain_topology. 

    It's a legacy from when it didn't have an ld pointer to access ld's
timer structure.  Now it's just confusing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e72e152 View commit details
    Browse the repository at this point in the history

  2. lightningd: disable topology timers on shutdown. 

    Not necessary yet, but it will be once shutdown starts waiting for
plugins to respond: we don't want these to try to access the bcli
plugin once it's freed.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c34f5a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. lightningd: call "shutdown" notification on plugins at shutdown. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: Plugins: `shutdown` notification for clean exits.
    @rustyrussell
    rustyrussell committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    4306e65 View commit details
    Browse the repository at this point in the history

  2. libplugin: plugin_exit helper which flushes stdout. 

    We weren't actually getting the last log out; this does that.

We have to fix test_bitcoin_failure which now notices the BROKEN
log message.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: libplugin: Fatal error messages from plugin_exit() now logged in lightningd.
    @rustyrussell
    rustyrussell committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7c39885 View commit details
    Browse the repository at this point in the history

  3. lightningd: call shutdown plugin when we dynamic shutdown a single one. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    28bdff3 View commit details
    Browse the repository at this point in the history

  4. doc: document shutdown plugin. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    4106888 View commit details
    Browse the repository at this point in the history