df: check mempool/block for funding output on broadcast fail #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can't broadcast the tx, confirm that it didn't end up in the mempool or the utxo set before throwing an error. Note that this doesn't protect us in the case where the funding output has already been *spent*... but that's extremely rare, right? Fixes ElementsProject#5296 Reported-By: @rustyrussell Collab-With: @vincenzopalazzo
There was a problem hiding this comment.
Concept ack
This PR solves the lnprototest issue rustyrussell/lnprototest#31 before ack it we need to rebase on master and make sure that also the CI is happy with that! :)
This was referenced Jul 3, 2022
|
superceded by #5372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can't broadcast the tx, confirm that it didn't end up in the
mempool or the utxo set before throwing an error.
Note that this doesn't protect us in the case where the funding
output has already been spent... but that's extremely rare, right?
Fixes #5296
Reported-By: @rustyrussell
Collab-With: @vincenzopalazzo