core-lightning: restart bitcoind when we're restarted. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores previous behavior (we had bugs, so we just changed to restarting it every time). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I found a similar race in our core-lightning CI: when a node restarts, there's a race where another node could start on the same port. In this case, we catch the exception, which was covering up the failure. The test then talks to the wrong bitcoind, which has unpredictable results. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
bitcoind-restart
branch
from
ee6e5f0 to
cc020d4
Compare
|
The only regression that we have with this PR is the execution time of the test, In particular:
I will check this in local and see what is going on! |
|
See final fixup commit! If we don't rewrite the bitcoin.conf when we change port, it all breaks... |
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
Closing in favor of #53 that includes a patch of this patch. In addition, the CI now run @niftynei cln patch ElementsProject/lightning#5367 so we start to monitoring other CI failure, but at the moment this problem looks fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody else seems to, which explains some of our issues?
No, still failing. Let me add a crapton of logging, since it only fails on GH!
Fixes #31