coop-close channel integration testing

[vincenzopalazzo]

Build on top of #47

This is one of my first attempts to implement the interoperability test for the shutdown workflow described in BOLT2

This should clarify the idea on the implementation side about the following discussion lightning/bolts#964 and lightning/bolts#970

This will override the c-lightning CI flaky test https://github.com/ElementsProject/lightning/pull/4985/files/93f8a11bf60ad9809ced69c9be0ae7ccf922b2eb..7530018014128a24a42f816ab0676cb85f9e96c8#diff-72d78e7a968ac6b078b7a2d84e56d2e026c54f60e56781f878664bcaae4b2bfbR3441

[michaelfolkson]

Concept ACK. More testing around cooperative closing is good :)

The motivation for this (as I understand from the c-lightning call) is when a lnprototest test fails bitcoind isn't stopped? Firstly I'm not sure why bitcoind should be stopped if a lnprototest test fails (I guess it depends on the test) and secondly I'm not sure how the code in this PR resolves that. Can you explain?

[vincenzopalazzo]

Concept ACK. More testing around cooperative closing is good :)

Yes, also because we have a little bit of confusion across definition of coop-close in the spec like lightning/bolts#970 (comment) and lightning/bolts#964

The motivation for this (as I understand from the c-lightning call) is when a lnprototest test fails bitcoind isn't stopped? Firstly I'm not sure why bitcoind should be stopped if a lnprototest test fails (I guess it depends on the test) and secondly I'm not sure how the code in this PR resolves that. Can you explain?

Sorry if I miss the point to the PR, this problem is fixed by the following PR #38 In particular if a test fails or lnprototest was not able to clear the work dir in the /tmp and sto bitcoind to work because the following code was missing

lnprototest/lnprototest/clightning/clightning.py

Lines 166 to 170 in ceeb866

	def shutdown(self) -> None:
	for cb in self.cleanup_callbacks:
	cb()
	self.rpc.stop()
	self.bitcoind.stop()

and also all the lnprototest flow between start -> shutdown -> stop was rewritten

[vincenzopalazzo]

ovveride by #62