msggen: Add decode and decodepay to the mapped bindings #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use overrides that omit fields in some cases, which makes the conversion lossy. This also means that until we complete the mapping we can't reconvert back.
This is still a huge response, so we better make sure we can actually convert it correctly.
IN/OUT => LOCAL/REMOTE
We were using per-type overrides which caused some asymmetries, where conversions could end up dropping fields as we went along. Essentially each conversion would need to override a superset of the previous one, which then caused issues when attempting to close the loop. By overriding on the model level we ensure that all representations are equivalent and convertible into one another, at the expense of overriding a bit more aggressively, which should be fine anyway.
cdecker
force-pushed
the
202318-grpc-decodepay
branch
2 times, most recently
from
163f82f
to
7bb6dca
Compare
cdecker
force-pushed
the
202318-grpc-decodepay
branch
from
7bb6dca
to
3098a5b
Compare
Changelog-Added: grpc: Added mapping for `listpeerchannels`, `listclosedchannels`, `decode` and `decodepay` RPC method
cdecker
force-pushed
the
202318-grpc-decodepay
branch
from
3098a5b
to
5dc3a0b
Compare
|
Added a Changelog-Added entry describing all 3 PRs in this stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #6222 and starts at 51eecab
We had to do some drive-by fixes, and improvements to msggen itself:
But the meat of the PR is the addition of
decodeanddecodepay, as such it should replace #6212Closes #6212