Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msggen: Add decode and decodepay to the mapped bindings #6229

Merged
merged 12 commits into from
May 5, 2023
Merged

msggen: Add decode and decodepay to the mapped bindings #6229

merged 12 commits into from
May 5, 2023

Commits on May 3, 2023

  1. jsonrpc: Add versioning annotation to listpeerchannels

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4a2d702 View commit details
    Browse the repository at this point in the history

  2. msggen: Add ListPeerChannels to generated interfaces

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0304139 View commit details
    Browse the repository at this point in the history

  3. msggen: Normalize enum and field names if they contain a '/'

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9be978e View commit details
    Browse the repository at this point in the history

  4. msggen: Disable grpc response -> json response temporarily 

    We use overrides that omit fields in some cases, which makes the
conversion lossy. This also means that until we complete the mapping
we can't reconvert back.
    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ff8b15a View commit details
    Browse the repository at this point in the history

  5. pytest: Add a test for the grpc conversion of listpeerchannels 

    This is still a huge response, so we better make sure we can actually
convert it correctly.
    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    69ac062 View commit details
    Browse the repository at this point in the history

  6. msggen: Add ListClosedChannels and overrides

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a2b168b View commit details
    Browse the repository at this point in the history

  7. cln-grpc: Rename the ChannelSide variants 

    IN/OUT => LOCAL/REMOTE
    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0510537 View commit details
    Browse the repository at this point in the history

  8. pytest: Extend ListPeerChannels test to include ListClosedChannels

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c395cc3 View commit details
    Browse the repository at this point in the history

  9. jsonrpc: Add request schemas for decode and decodepay

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    51eecab View commit details
    Browse the repository at this point in the history

  10. msggen: Move overrides into the model itself 

    We were using per-type overrides which caused some asymmetries, where
conversions could end up dropping fields as we went along. Essentially
each conversion would need to override a superset of the previous one,
which then caused issues when attempting to close the loop. By
overriding on the model level we ensure that all representations are
equivalent and convertible into one another, at the expense of
overriding a bit more aggressively, which should be fine anyway.
    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b961e23 View commit details
    Browse the repository at this point in the history

  11. msggen: Map arrays of hashes and add HtlcState enum

    @cdecker
    cdecker committed May 3, 2023
    Configuration menu
    Copy the full SHA
    20b7b8c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. msggen: Add DecodePay to the mappings 

    Changelog-Added: grpc: Added mapping for `listpeerchannels`, `listclosedchannels`, `decode` and `decodepay` RPC method
    @cdecker
    cdecker committed May 4, 2023
    Configuration menu
    Copy the full SHA
    5dc3a0b View commit details
    Browse the repository at this point in the history