build: fix Ros2 humble build #36
Conversation
|
@tfoldi could you please provide a description about the issue you resolved, and some proofs? |
| include_directories(include) | ||
| include_directories(/opt/ros/humble/include/tf2_geometry_msgs) |
There was a problem hiding this comment.
Removed any hardcoded path to ensure it will compile on all ROS2 deployments like robostack, source builds, etc.
| - humble | ||
| - iron | ||
| - rolling | ||
| include: |
There was a problem hiding this comment.
Add CI/CD build test for humble, iron and rolling
| @@ -54,27 +50,30 @@ add_library(witmotion_ros | |||
|
|
|||
| message(WARNING "tf2_geometry_msgs include dir: ${tf2_geometry_msgs_INCLUDE_DIRS} ") | |||
|
|
|||
| #find_package(Qt5 REQUIRED COMPONENTS Core SerialPort) | |||
| set(INCLUDE_DIRS ${ament_cmake_INCLUDE_DIRS} ${tf2_INCLUDE_DIRS} | |||
There was a problem hiding this comment.
change CMAKE style dependency management to more idiomatic ament_target_dependencies
|
|
||
| <buildtool_depend>ament_cmake</buildtool_depend> | ||
| <buildtool_depend>ament_cmake_auto</buildtool_depend> | ||
|
|
||
| <depend>tf2_geometry_msgs</depend> |
There was a problem hiding this comment.
add depend to ensure rosdep can install all required dependencies
|
hey @twdragon, the following changes were applied:
I made a few comments on the relevant code lines, hope that helps. Should you have any question please let me know In general, other than the project definition and make files no |
|
I build this branch successfully with ROS 2 Jazzy. Can this one merge to the main? |
No description provided.