Make it a bash script to fix job control on CI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shell job control is mainly for interactive use, and shells vary in the situations where it is supported. In the noninteractive session on CI, the "set -m" command in the run-experiment script failed on Ubuntu, where /bin/sh is dash, but succeeded on macOS, where /bin/sh is (I think) bash 3.2. This change makes it work on both. Besides its somewhat unusual use of job control, this script otherwise currently relies on no "bash-isms". (SSHing in for tmate was never affected by this, but the main point of CI is noninteractive use, so I want that to work on both systems.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell job control is mainly for interactive use, and shells vary in the situations where it is supported. In the noninteractive session on CI, the
set -mcommand in the run-experiment script failed on Ubuntu, where/bin/shisdash, but succeeded on macOS, where/bin/shis (I think)bash3.2. This change makes it work on both.Besides its somewhat unusual use of job control, this script otherwise currently relies on no "bash-isms".
(SSHing in for tmate was never affected by this, but the main point of CI is noninteractive use, so I want that to work on both systems.)