Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it a bash script to fix job control on CI #2

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Make it a bash script to fix job control on CI #2

merged 1 commit into from
Dec 5, 2023

Commits on Dec 5, 2023

  1. Make it a bash script to fix job control on CI 

    Shell job control is mainly for interactive use, and shells vary in
the situations where it is supported. In the noninteractive session
on CI, the "set -m" command in the run-experiment script failed on
Ubuntu, where /bin/sh is dash, but succeeded on macOS, where
/bin/sh is (I think) bash 3.2. This change makes it work on both.

Besides its somewhat unusual use of job control, this script
otherwise currently relies on no "bash-isms".

(SSHing in for tmate was never affected by this, but the main point
of CI is noninteractive use, so I want that to work on both
systems.)
    @EliahKagan
    EliahKagan committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c8d6533 View commit details
    Browse the repository at this point in the history