Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #45

Merged
merged 3 commits into from
Jan 18, 2016
Merged

Fix tests #45

merged 3 commits into from
Jan 18, 2016

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Jan 16, 2016

Fixes tests after 53f3430.

Also pins jQuery to 1.11.3 as a work-a-round for this bug in ember.js: emberjs/ember.js#12793

@jelhan
Copy link
Contributor Author

jelhan commented Jan 16, 2016

53f3430 looks really not finished. fmConfig.showErrorsByDefault is only implemented for fm-field. The other components are untouched. Therefore behaviour is inconsistently.

Also I'm a little bit confused about the releases. You released a new version including #38 which changes default behaviour and directly afterwards made a commit which changes default behaviour again. What's the desired defaults?

@g-cassie
Copy link
Collaborator

Thanks @jelhan. I will try to look at this in the next couple days.

Just to fill you in, I met in person with @Emerson and we are planning to do a bit of a refactor of this library to clean up all the loose ends and provide good solutions for some of the problems that have come up (validation, custom templates, etc.). We are still working on nailing down the API but we may make the refactor require Ember 2.3+ so we can use the new yielded components feature.

g-cassie added a commit that referenced this pull request Jan 18, 2016
[Bugfix] Fix tests that broke in previous commits.
@g-cassie g-cassie merged commit 4d5feac into Emerson:master Jan 18, 2016
@jelhan
Copy link
Contributor Author

jelhan commented Jan 18, 2016

8b1aef4 is not needed any more since Ember.js 2.3.0, 2.2.2 and 1.13.13 were released.

Emerson added a commit that referenced this pull request Jan 19, 2016
Adds a couple bug fixes from PR #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants