Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

[WIP] Update initialization procedure #62

Merged
merged 49 commits into from
Jul 11, 2020
Merged

Conversation

rodrigomha
Copy link
Member

@rodrigomha rodrigomha commented Jul 9, 2020

The following PR provides initialization methods for each component. It also adds tests for AndersonMachines, and removes models for Kundur Machines that currently are not working. Now all the tests use RAW files to initialize the system.

Initializations to do:

  • AVRSimple
  • AVRTypeII
  • PSSSimple
  • TGTypeI

Test 11 of DynamicLines is waiting for update in PSY.

I will probably add a test for all of those devices together in a ThreeBusNetwork.raw. In addition, I think is possible to now properly create the LCFilter model. However, this possibly will create conflicts with states that will not longer exists, and will require the implementation of additional inverter inner vars.

@rodrigomha rodrigomha requested a review from jd-lara July 9, 2020 22:26
@jd-lara jd-lara self-assigned this Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #62 into jd/update_test_files will increase coverage by 10.34%.
The diff coverage is 90.98%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           jd/update_test_files      #62       +/-   ##
=========================================================
+ Coverage                 75.25%   85.59%   +10.34%     
=========================================================
  Files                        30       44       +14     
  Lines                      1075     1812      +737     
=========================================================
+ Hits                        809     1551      +742     
+ Misses                      266      261        -5     
Impacted Files Coverage Δ
src/LITS.jl 100.00% <ø> (ø)
...itialization/inverter_components/init_converter.jl 0.00% <0.00%> (ø)
src/models/device.jl 100.00% <ø> (ø)
src/models/generator_models/shaft_models.jl 100.00% <ø> (ø)
...rc/initialization/generator_components/init_avr.jl 41.02% <41.02%> (ø)
src/models/system.jl 78.18% <66.66%> (-21.82%) ⬇️
src/base/file_system.jl 80.00% <80.00%> (ø)
src/base/simulation_initialization.jl 83.78% <83.78%> (ø)
src/base/simulation.jl 84.07% <90.90%> (-10.35%) ⬇️
src/initialization/generator_components/init_tg.jl 96.42% <96.42%> (ø)
... and 39 more

@rodrigomha rodrigomha marked this pull request as ready for review July 11, 2020 01:18
@jd-lara jd-lara merged commit ce6fbea into jd/update_test_files Jul 11, 2020
@jd-lara jd-lara deleted the rh/init_models branch July 11, 2020 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants