Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running clippy. #13

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Running clippy. #13

merged 1 commit into from
Sep 15, 2019

Conversation

pauldotknopf
Copy link
Contributor

Should we add these checks to the build server?

@Enet4
Copy link
Owner

Enet4 commented Sep 15, 2019

These look good, thank you!

Adding Clippy to CI could be done, but not without extra care, since not all toolchains may have it successfully built and available. As a noteworthy example, the Rustup clippy tool hasn't been available since nightly-2019-09-14 (see Rustup components history). We can include it, but a successful installation should not be mandatory.

@Enet4 Enet4 merged commit 24342c5 into Enet4:master Sep 15, 2019
@pauldotknopf pauldotknopf deleted the clippy branch September 15, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants