Running clippy.

dcmdump/src/main.rs

@@ -31,8 +31,8 @@ fn main() -> DynResult<()> {
         Err(ref e) if e.kind() == ErrorKind::BrokenPipe => {
             Ok(()) // handle broken pipe separately with a no-op
         }
-        Err(e) => Err(e)?, // raise other errors
-        _ => Ok(()),       // all good
+        Err(e) => Err(e.into()), // raise other errors
+        _ => Ok(()),             // all good
     }
 }
 

object/src/meta.rs

@@ -92,7 +92,7 @@ where
 }
 
 impl FileMetaTable {
-    pub fn from_reader<R: Read>(file: R) -> Result<FileMetaTable> {
+    pub fn from_reader<R: Read>(file: R) -> Result<Self> {
         FileMetaTable::read_from(file)
     }
 
@@ -464,5 +464,4 @@ mod tests {
         assert_eq!(table.private_information_creator_uid, None);
         assert_eq!(table.private_information, None);
     }
-
 }

parser/src/parser.rs

@@ -709,7 +709,7 @@ fn parse_time_impl(buf: &[u8], for_datetime: bool) -> Result<(NaiveTime, &[u8])>
             let mut n = usize::min(6, buf.len());
             if for_datetime {
                 // check for time zone suffix, restrict fraction size accordingly
-                if let Some(i) = buf.into_iter().position(|v| *v == b'+' || *v == b'-') {
+                if let Some(i) = buf.iter().position(|v| *v == b'+' || *v == b'-') {
                     n = i;
                 }
             }
@@ -789,11 +789,9 @@ where
 {
     debug_assert!(!buf.is_empty());
     debug_assert!(buf.len() < 10);
-    (&buf[1..])
-        .into_iter()
-        .fold((buf[0] - b'0').into(), |acc, v| {
-            acc * T::ten() + (*v - b'0').into()
-        })
+    (&buf[1..]).iter().fold((buf[0] - b'0').into(), |acc, v| {
+        acc * T::ten() + (*v - b'0').into()
+    })
 }
 
 fn parse_datetime(buf: &[u8], dt_utc_offset: FixedOffset) -> Result<DateTime<FixedOffset>> {

transfer-syntax-registry/src/lib.rs

@@ -1,7 +1,7 @@
 //! This crate contains the DICOM transfer syntax registry.
 //! The transfer syntax registry maps a DICOM UID of a transfer syntax into the
 //! respective transfer syntax specifier.
-//! 
+//!
 //! This registry should not have to be used directly, except when developing
 //! higher level APIs, which should learn to negotiate and resolve the expected
 //! transfer syntax automatically.