WiP: Include all syntaxes in minimal syntaxes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enselic
force-pushed
the
include-all-syntaxes-in-minimal-syntaxes
branch
4 times, most recently
from
2a702c1 to
be1a62e
Compare
By forwarding the task to find the Plain Text syntax to assets. Not only does the code become simpler; we also get rid of a call to `self.get_syntax_set()` which is beneficial to the long term goal of replacing `syntaxes.bin` with `minimal_assets.bin`.
To make the code easier to refactor further.
…tax_for_path() We can do this since the file_name() of a file_name is file_name.
Each syntaxes is in minimal_syntaxes.bin once, so size is just slightly bigger than syntaxes.bin.
Enselic
force-pushed
the
include-all-syntaxes-in-minimal-syntaxes
branch
from
be1a62e to
3829135
Compare
|
This is a dead end. I have made syntect lazy load syntaxes instead. See trishume/syntect#398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This branch will be force pushed
The only thing left to do in terms of functionality as far as I know is to support creating custom assets with all integrated syntaxes included. This is currently tricky since syntaxes are split up in many syntax sets, but .into_builder() only operates on a single syntax set at a time. But I'm sure it is possible to make that work somehow.