Track dependents for each syntax #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we later can use it for not only information about dependencies, but also for information about dependents.
It makes more sense structurally when we later introduce SyntaxToDependents.
keith-hall
reviewed
Sep 21, 2021
keith-hall
approved these changes
Sep 22, 2021
|
Thanks for review! (I will do a force-push to restore original commit structure before I merge) |
This information is useful when you want to build several SyntaxSets, but without having to duplicate SyntaxDefinitions. For example: "Rust" has no dependencies. But "Markdown" depends on "Rust". With the data structures this code adds, we know that "Rust" is a dependent syntax for "Markdown", and can construct a SyntaxSet that takes that into account. Note that code has a temporary environment flag to ignore any information about dependents when constructing SyntaxSets. Code that makes use of the new data structure will be added later.
Enselic
force-pushed
the
track-syntax-dependents
branch
from
4d9c396 to
f77ff1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #951 continues, and I now have work-in-progress code where
syntaxes.binhas been removed, and every syntax is present inminimal_syntaxes.bin. Notably, without duplicates, so the size ofminimal_syntaxes.binis the same assyntaxes.bin, differing only by some tens of kbs. See Enselic#38.While there still are problems to solve, I am confident in some parts of the code, and will
startcontinue to create separate PRs to take the code base in that direction. (Actually, #1856 is also this kind of PR.)This PR consists of three commits. The first commit just renames stuff in preparation for the third commit. The second commits just moves code around a bit to fit better with the third commit. The "real" code is in the third commit. It adds code to add information about what dependents a syntax has. For example, the Rust syntax is a dependent for the Markdown syntax, because Markdown depends on Rust via
embed: scope:source.rust.Knowing the dependents of a syntax is useful when constructing
SyntaxSets without duplicateSyntaxReferences (and is used in Enselic#38).While this code adds info about syntax dependents, there is a temporary env var flag that makes it not used yet when building assets. The env var will be removed later, and the dependents info will start being used when building assets.