Fall back to "Plain Text" if embeds are missing #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be how Sublime Text also behaves.
Enselic
pushed a commit
that referenced
this pull request
Jan 7, 2022
So that we can add variants and variant fields without semver breakage. This will likely be needed to fall back to "Plain Text" if embeds are missing. See prototype code at #6
Enselic
added a commit
that referenced
this pull request
Jan 7, 2022
So that we can add variants and variant fields without semver breakage. This will likely be needed to fall back to "Plain Text" if embeds are missing. See prototype code at #6
|
Obsoleted by trishume#427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, syntect (and bat, see sharkdp/bat#915) panics for syntaxes that tries to embed a scope (typically another language) that is not present.
However, in the same scenario, Sublime Text does not crash. Instead, Sublime seems to fallback to Plain Text syntax, which actually seems very reasonable. Because
embeds always have anescapeout of the Plain Text.This PR implements falling back to Plain Text if embeds are missing.
I'm marking this as Draft because
contextsfromSyntaxSetinto individualSyntaxReferences trishume/syntect#382 which is not merged yetI would love to get your early feedback on this approach before I polish it further. Do you think this could work?