For 5.0.0: ContextReference: Mark as #[non_exhaustive]
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can add variants and variant fields without semver breakage. This will likely be needed to fall back to "Plain Text" if embeds are missing. See prototype code at #6
Enselic
force-pushed
the
mark-ContextReference-non_exhaustive
branch
from
be69802 to
fc13bdf
Compare
trishume
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an adventurous PR.
This is so that we can add variants and variant fields without semver breakage. This
will likely be needed to fall back to "Plain Text" if embeds are missing. See
prototype code at Enselic#6 and discussion at sharkdp/bat#915 (comment). It would be nice to be able to fix that without requiring a major bump in syntect, and this PR should make that possible, with some luck.
If this gets merged for 5.0.0 I will add a CHANGELOG.md entry for it in #409 later (same with my other PRs)