-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for breakend variants from VCF #1399
Add support for breakend variants from VCF #1399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nuno-agostinho , thank you for this. Tested parsing of alt allele with different examples and seems to be working as expected. Test cases look good. In this iteration, do we also plan to support alt alleles like C[<ctg1>: 1[
?
Thanks for testing @likhitha-surapaneni! I would say that support for contigs is not as urgent, but it is something we may want to think about in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with logic @nuno-agostinho , thanks for testing examples @likhitha-surapaneni
To backport for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @nuno-agostinho
|
ENSVAR-2086, fixes #437, #441 and #782
Logic
SVTYPE=BND
in INFO field or<BND>
in ALT field, for instance:A[chr22:22893780[
in ALT field orCHR2=chr22;END2=20098034
in INFO field), create a hashref with chromosome, position, placement (before/after) and if mate is invertedA[chr22:22893780[,CT[chrX:10932343[
Technical changes
get_source_chr_name()
now works when$self->valid_chromosomes
is hashref (instead of arrayref only)min_max
changed from arrayref$min_max = [$min, $max]
to hashref$min_max->{chr} = [$min, $max]
min
andmax
coordinates per chromosomefilter_features_by_min_max()
updated to take into account the chromosomeA[chr22:22893780[
(fixes ERROR: Can't detect input format #782)Potential improvements missing
Unit testsAdded11 94987872 MantaBND:0:0:1:0:0:0:0 T ACTCCT[8:107653411[
Report which breakend is associated with each transcript consequenceDone in Report consequences for each breakend (e112) #1496Some code could/should be moved to ensembl-variationDone in Report consequences for each breakend (e112) #1496Testing
Run VEP with different examples and check if the consequences make sense. You can use this VCF to test the changes:
Some of the BND examples were retrieved from: