Split the block into separate packages for each database #39

tsahi · 2020-09-28T20:07:45Z

Is your feature request related to a problem? Please describe.
Today there is one big package that supports SQL Server, Oracle, and SqlCE. There is no reason people using SQL Server will take a dependency on packages supporting Oracle, and vice-versa.

Describe the solution you'd like
We should split the package to several packages, so that:

One base package will carry the base functionality, e.g. the abstract Database class, the caching, etc.
A SQL Server package will depend on the base package, but will also depend on Microsoft.Data.SqlClient.
An Oracle package will depend on the base package, but will also depend on Oracle.ManagedDataAccess[.Core]
A SqlCE package will depend on the base package. This won't bring new dependencies.
A Generic (very small) package will depend on the base package, exposing the GenericDatabase for use with OldDb provider.

tsahi · 2020-10-09T13:54:31Z

As I see it, the root problem is at DatabaseSyntheticConfigSettings, which has references to three different Database derivatives: SqlDatabase, OracleDatabase and GenericDatabase, which is used for anything else, unless you configured a specific Database derivative. They are used in GetDefaultMapping(string), which tries to guess the right mapping based on the provider name, when a provider is not configured in the <dataConfiguration> section.

This allows users to create a database provider for SQL Server or Oracle even without mapping a provider in the configuration, just by providing a connection string name. DAAB will read the providerName attribute and return the right provider.

We can see how this works in the Data.SqlCe.Tests.VSTS project. If you look at the SqlCeDatabaseFixture test class, you can see how it registers the SqlCeDatabase with the System.Data.SqlServerCe.4.0 in code, and then passes this configuration to DatabaseProviderFactory so it can produce the right provider.

So if we split the Data project to separate projects and assemblies for each database provider, we'll have to require users to map their provider name to database provider in configuration.

tsahi · 2020-10-09T18:03:28Z

This is a major change, and I plan to make several PRs for it. But if I merge partial changes to master, we won't be able to make new releases (or it will become difficult). So I suggest I branch from master, update my fork, and work on it on that branch in my fork. Then, I'll make a PR from the branch on my fork to the branch in this fork. What do you think?

EnterpriseLibrary#39

register OracleDatabase in configuration. EnterpriseLibrary#39

EnterpriseLibrary#39

register data provider for .net core. EnterpriseLibrary#39

EnterpriseLibrary#39

…tation. EnterpriseLibrary#39

* move OracleDatabase and related code to a Data.Oracle project. #39 * remove unused usings, reference to Oracle in XML comments #39 * move types n OracleConfigurationExtension.cs to their own file #39 * add reference to Data.Oracle to TestSupport project, so it compiles. #39 * fix namespace #39 * use nameof() #39 * fix config section assembly name register OracleDatabase in configuration. #39 * fix package versioning #39 * add a mapping of OracleDatabase to synthetic configuration. #39 * add configuration of an oracle database provider #39 * register OracleDatabase provider; fix assembly name for section handler. register data provider for .net core. #39 * map oracle database provider #39 * add the Data.Oracle project and fix usings #39 * add oracle database provider configuration * add oracle database provider registration #39 * remove reference to oracle nuget package #39 * move common code to extension method #39

remove package from Data project #39

#39

…ects #39

#39

add reference to System.Data.Odbc NuGet package add links to GlobalAssemblyInfo.cs and DataAccess.licenseheader include Nuget\readme.txt fix Data.Odbc namespace add missing Apache 2.0 license boilerplate on original code. #39

#39.

#39

Add ODBC database provider to test config make OdbcDatabaseData constructor publc #39

…r.Compact NuGet package #39

#39

replace <devdoc> with <summary> remove trailing whitespace. #39

tsahi · 2021-01-02T12:14:37Z

As you can see from the commits above, I ended up creating an OleDbDatabase and OdbcDatabase, in two separate projects/packages. This is because each of them carries it's own package dependency, depending on the target framework.

So now we have:

Data: common infrastructure, and the GeneralDatabase which can be used for databases not directly supported by DAAB
Data.SqlServer: for SQL Server support
Data.Oracle: for Oracle support
Data.SqlCe: for SQL CE support
Data.OleDb: for OLE DB providers support
Data.Odbc: for ODBC providers support.

#39

embed icon in package instead of pulling it from another package on nuget.org #39

#39

add Enterprise Library Open Source Project as copyright owner #39

#39

tsahi · 2021-01-09T17:31:02Z

This is essentially done. support for Microsoft.Data.SqlClient will be done at #38 .

#39

tsahi added the enhancement New feature or request label Sep 28, 2020

tsahi changed the title ~~Split the block into sparate packages for each database~~ Split the block into separate packages for each database Oct 4, 2020

tsahi self-assigned this Oct 9, 2020

tsahi added this to the 7.0 milestone Oct 10, 2020

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

move OracleDatabase and related code to a Data.Oracle project.

b78056a

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

remove unused usings, reference to Oracle in XML comments

d301cc5

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

move types n OracleConfigurationExtension.cs to their own file

dcd7e19

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

add reference to Data.Oracle to TestSupport project, so it compiles.

2142e11

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

fix namespace

45de223

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

use nameof()

d9ac732

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

fix config section assembly name

ff496ca

register OracleDatabase in configuration. EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

fix package versioning

3db1ef1

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

add a mapping of OracleDatabase to synthetic configuration.

3ae2c44

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

add configuration of an oracle database provider

8bacad1

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

register OracleDatabase provider; fix assembly name for section handler.

c24c2e8

register data provider for .net core. EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

map oracle database provider

531c9cc

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

add the Data.Oracle project and fix usings

e350147

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

add oracle database provider registration

775f1c9

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 17, 2020

remove reference to oracle nuget package

274e56d

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 18, 2020

move common code to extension method

a4b974c

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 30, 2020

move support for SQL Server to a separate project

65743b6

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 30, 2020

remove direct reference to SqlDatabase in comments

65c5f0d

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 30, 2020

add reference to Data.SqlServer and fix usings

43563d0

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Oct 30, 2020

register SqlDatabase provider in config

d6cf2c5

EnterpriseLibrary#39

tsahi mentioned this issue Oct 31, 2020

Milestone 7.0 #43

Open

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Nov 3, 2020

[Ignore] default detection of SQL Server data provider

fb6e313

EnterpriseLibrary#39

tsahi added a commit to tsahi/EnterpriseLibrary-data-access-application-block that referenced this issue Nov 3, 2020

[Ignore] tests that expect SqlDatabase as a default Database implemen…

fc948c3

…tation. EnterpriseLibrary#39

tsahi added a commit that referenced this issue Dec 20, 2020

enable OLE DB for netstandard 2.0

b0cfa87

remove package from Data project #39

tsahi added a commit that referenced this issue Dec 20, 2020

fix OLE DB tests

156ed34

#39

tsahi added a commit that referenced this issue Dec 25, 2020

comments

e35a3c9

#39

tsahi added a commit that referenced this issue Dec 25, 2020

move OleDbDatabaseData to Configuration folder, as it's in other proj…

7657562

…ects #39

tsahi added a commit that referenced this issue Dec 25, 2020

Add Data.Odbc project

dd7fcbe

#39

tsahi added a commit that referenced this issue Dec 25, 2020

add tag

563eb0d

#39

tsahi added a commit that referenced this issue Dec 25, 2020

move ODBC related code to Data.Odbc project

6eb68db

#39.

tsahi added a commit that referenced this issue Dec 25, 2020

add reference to Data.Odbc project, and fix namespaces.

e562c4a

#39

tsahi added a commit that referenced this issue Dec 26, 2020

add reference to Data.Odbc.

980560d

Add ODBC database provider to test config make OdbcDatabaseData constructor publc #39

tsahi added a commit that referenced this issue Dec 26, 2020

replace System.Data.SqlServerCe.dll reference with Microsoft.SqlServe…

27baef3

…r.Compact NuGet package #39

tsahi added a commit that referenced this issue Dec 26, 2020

OK, so we can't support parameter discovery for ODBC

03a1e0c

#39

tsahi added a commit that referenced this issue Dec 28, 2020

add test that the Oracle OLE DB does not support parameter discovery

d26e0b3

#39

tsahi added a commit that referenced this issue Jan 1, 2021

use nameof() for ArgumentException

2059527

replace <devdoc> with <summary> remove trailing whitespace. #39

tsahi added a commit that referenced this issue Jan 2, 2021

fix test of config file

ed5db28

#39

tsahi added a commit that referenced this issue Jan 2, 2021

Test that ODBC database provider is created correctly

1794a07

#39

tsahi added a commit that referenced this issue Jan 2, 2021

fix test

a248a50

#39

tsahi added a commit that referenced this issue Jan 9, 2021

fix reference to package icon

9c0d26e

embed icon in package instead of pulling it from another package on nuget.org #39

tsahi added a commit that referenced this issue Jan 9, 2021

change XML to how VS generates it

b42a82c

#39

tsahi added a commit that referenced this issue Jan 9, 2021

change dependency on preview versions of packages to stable versions

68137ae

#39

tsahi added a commit that referenced this issue Jan 9, 2021

fix configuration for OdbcDatabase

064de7f

#39

tsahi added a commit that referenced this issue Jan 9, 2021

upgrade version to RC1

0248d34

add Enterprise Library Open Source Project as copyright owner #39

tsahi added a commit that referenced this issue Jan 9, 2021

move <OutputPath> to package.props

6211608

#39

tsahi added a commit that referenced this issue Jan 9, 2021

generate NuGet packages when building Release.

28e3230

#39

tsahi closed this as completed Jan 9, 2021

tsahi added a commit that referenced this issue Feb 5, 2021

fix unit tests

2b28ce0

#39

tsahi added a commit that referenced this issue Feb 21, 2021

remove OutputPath, so it uses the common one.

29bb206

#39

tsahi mentioned this issue Jan 14, 2022

Milestone7.0 #51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split the block into separate packages for each database #39

Split the block into separate packages for each database #39

tsahi commented Sep 28, 2020

tsahi commented Oct 9, 2020

tsahi commented Oct 9, 2020

tsahi commented Jan 2, 2021

tsahi commented Jan 9, 2021

Split the block into separate packages for each database #39

Split the block into separate packages for each database #39

Comments

tsahi commented Sep 28, 2020

tsahi commented Oct 9, 2020

tsahi commented Oct 9, 2020

tsahi commented Jan 2, 2021

tsahi commented Jan 9, 2021