Improvements on creation of geometry and meshing by GMSH #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsure consistent airgap regions
|
Thank you for your contribution, this looks very interesting :) Starting from next week I should have more time for pyleecan (we are about to release the next version of our commercial software). I will try to review your PR (and the other pending one) by then. @SebGue Do you think you can take a look as well ? Best regards, |
|
Hello, I'm currently reviewing this PR and I find few things to correct but otherwise its a great step forward thank you :) Best regards, |
This was referenced Mar 2, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will improve the geometry and mesh generation through gmsh. The code has been rewritten to use OCC kernel instead, and this allows to perform boolean operations for the better creation of surfaces in the air gap. The sliding band is being drawn in such a way that is compatible with the magnetics solvers in Elmer fem.
Additionally, this pull request will allow to create and mesh almost all the example geometries available in the database:
pyleecan/Data/Machine .
There will be future improvements to support outer rotor topologies. Currently, the outer rotor geometries can be drawn without sliding band.
I am also trying to identify and fix some of the boundary condition settings that seems to be inconsistent with how those are currently treated in pyleecan.
GUI has a button to create gmsh file and default to sym=1, it would be good that defaults to is_sliding_band=False and is_airbox=False too.