GMSH and Elmer #624
Merged
GMSH and Elmer #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Removing MyProjects folder from repo
No needed in the PR
|
Hello, Thank you for your PR, I will try to review it as soon as possible but most likely not this week. Best regards, |
|
Thank you for your contribution and sorry for the merge delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on PR #600 . The issue with boundary conditions on lines is fixed in this PR, and "test_magelmer.py" has been tested as well.
This PR uses OCC engine in Gmsh to perform boolean operations for drawing airgap and sliding band surfaces. After performing CUT operations, new resulting lines are searched for and set as physical lines to be used for MagElmer.
Most of geometries in the database are supported and can be converted into gmsh with any applied symmetry. However, Airbox region is still work in progress when geometry is drawn with sym=1.
Best,
Alejandro