Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify docker deployment process #33

Closed
hjwilli opened this issue May 31, 2018 · 3 comments
Closed

simplify docker deployment process #33

hjwilli opened this issue May 31, 2018 · 3 comments
Assignees
@hjwilli @weixuanfu

Comments

@hjwilli
Copy link
Collaborator

hjwilli commented May 31, 2018

Work has been done to consolidate the project into three docker containers in the pennai_lite branch:

  • lab - the main server; contains the a modified version of FGLab server, the webserver and the ai recommender
  • machine - contains a modified version of FGMachine
  • dbmongo - database server, structure somewhat defined by FGLab

This seems like a reasonable server configuration for now. Continue to to clean up the deployment process; continue to clean up and simplify Dockerfiles, add error checking to entrypoint.sh/startup.sh where appropriate, clean up dependencies, remove deprecated files, consolidate entrypoint.sh/start.sh files used by lab, clean up 'dockers/base' to only include what really needs to be shared, etc.
@weixuanfu weixuanfu self-assigned this Jun 1, 2018
hjwilli added a commit that referenced this issue Jun 1, 2018
@hjwilli
docker cleanup, working on removing git clone
c673e08 
Small dockerfile cleanup
Move git clone from base container to the subcontainers
References #35 #33
@weixuanfu
Copy link
Contributor

Instead of using git clone in Dockerfile to deploy, I create a lite version of pennai in /dockers/base/files/pennai.tar.gz to deploy pennai in this commit

hjwilli added a commit that referenced this issue Jun 7, 2018
@hjwilli
remove ml/ai dependencies from dbmongo
4994516 
References #33
hjwilli added a commit that referenced this issue Jun 19, 2018
@hjwilli
Speed up lab deployment
00f7588 
install pm2 globally when the docker image is being built, not every
time the container is started
move COPY entrypoint.sh to the end of the dockerfile to speed up
rebuilds
make the lab container more verbose
References #33
hjwilli added a commit that referenced this issue Jul 3, 2018
@hjwilli
machine waits for lab, test improvements
fc25144 
container dependencies added to docker-compose scripts
machine startup script waits for lab to be responsive
added jest int tests against machine container
jest int tests wait for both lab and machine to be up
jest int tests produce html output in ./tests/integration/resutls

References #40
References #33
@hjwilli
Copy link
Collaborator Author

hjwilli commented Aug 23, 2018

node_module docker management reference:

http://jdlm.info/articles/2016/03/06/lessons-building-node-app-docker.html
https://codefresh.io/docker-tutorial/node_docker_multistage/

hjwilli added a commit that referenced this issue Aug 23, 2018
@hjwilli
clean up machine build
df1a7e7 
- node_modules built with docker-compose build; automatically rebuilt
when machine/package.json updated
- node_modules now built in an anon container volume

References #33
hjwilli added a commit that referenced this issue Aug 23, 2018
@hjwilli
fewer lab docker layers, remove bundle.js
2158d68 
References #33
References #29
hjwilli added a commit that referenced this issue Aug 23, 2018
@hjwilli
all 'npm install' commands moved to docker build steps
387c0e5 
- lab node_modules built with docker-compose build; automatically
retuilt when lab/package.json or lab/webapp/package.json updated
- lab/node_modules and lab/webapp/node_modules now built in an anon
volume
- remove node_modules zip from the build

References #33
References #29
hjwilli added a commit that referenced this issue Aug 23, 2018
@hjwilli
Remove copy of static src files from base install
8e5eb2f 
References #33
Closes #35
@hjwilli hjwilli self-assigned this Aug 30, 2018
@hjwilli
Copy link
Collaborator Author

hjwilli commented Aug 30, 2018

closing for now

@hjwilli hjwilli closed this as completed Aug 30, 2018
HyunjunA added a commit that referenced this issue Jul 3, 2023
@HyunjunA
Merge pull request #33 from jay-m-dev/NickGPTBranch
05b661d 
Update comment for GenPlot component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjwilli hjwilli

@weixuanfu weixuanfu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjwilli @weixuanfu