Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic integration tests and a test runner #40

Closed
hjwilli opened this issue Jun 8, 2018 · 4 comments
Closed

Basic integration tests and a test runner #40

hjwilli opened this issue Jun 8, 2018 · 4 comments
Assignees
@hjwilli

Comments

@hjwilli
Copy link
Collaborator

hjwilli commented Jun 8, 2018

Currently there are some python unit tests written for the ai recommender and machine.

Create some basic integration tests and some sort of test runner that can run the integration tests and existing unit tests from the command line.
@hjwilli hjwilli self-assigned this Jun 8, 2018
hjwilli added a commit that referenced this issue Jun 12, 2018
@hjwilli
working on integration tests
58dcaf5 
docker-compose-int-test.yml will spin up lab, machine, dbmongo, and an
integration container that will run a suite of Jest tests.
The example 'sum' test passes, working on labApi tests

References #40
hjwilli added a commit that referenced this issue Jun 13, 2018
@hjwilli
passing integration tests!
917e3e4 
Test container waits for lab to be responsive before initiating tests

References #40
@hjwilli
Copy link
Collaborator Author

hjwilli commented Jun 13, 2018

First pass at integration tests and a docker test integration test runner.

To run the integration tests, from the root app directory run:
docker-compose -p integration-tests up --abort-on-container-exit

This will spin up lab, machine, and dbmongo containers as well as an integration test container that will wait till lab is responsive, run the tests and exit.

@weixuanfu weixuanfu mentioned this issue Jun 14, 2018
Merged
hjwilli added a commit that referenced this issue Jun 14, 2018
@hjwilli
expanded jest testing
e892ef7 
References #40
hjwilli added a commit that referenced this issue Jun 19, 2018
@hjwilli
better error response handling in tests
05b8bc2 
References #40
hjwilli added a commit that referenced this issue Jun 20, 2018
@hjwilli
test bugfix
66c7fd3 
#40
@hjwilli
Copy link
Collaborator Author

hjwilli commented Jun 20, 2018

Hi @weixuanfu, I updated main readme with instructions on running the int tests.

At this point, if the node packages have been fully installed in lab and machine and the database has been fully loaded, when I run the test suite 4/5 tests should pass. The test 'integration run simple experiment on adult' may fail with an error message along the line of 'no machine available'.

@weixuanfu
Copy link
Contributor

Thank you! I will test it in my environment.

hjwilli added a commit that referenced this issue Jun 20, 2018
@hjwilli
found that dos2unix dockerfile bug...
b9c783e 
found that dos2unix dockerfile bug when running the tests on a fresh
build

Ref #40
hjwilli added a commit that referenced this issue Jul 3, 2018
@hjwilli
machine waits for lab, test improvements
fc25144 
container dependencies added to docker-compose scripts
machine startup script waits for lab to be responsive
added jest int tests against machine container
jest int tests wait for both lab and machine to be up
jest int tests produce html output in ./tests/integration/resutls

References #40
References #33
hjwilli added a commit that referenced this issue Jul 6, 2018
@hjwilli
int test and machine updates
a24ab3e 
References #40
References #46
hjwilli added a commit that referenced this issue Jul 11, 2018
@hjwilli
cleanup and machine error output
d3e37bc 
Ref #40
hjwilli added a commit that referenced this issue Jul 11, 2018
@hjwilli
error reporting, cleanup, tests, ets
3258fad 
Better error reporting in lab and machine
implemented machine get /projects
lab .env dependency cleanup

References #52, References #40
hjwilli added a commit that referenced this issue Jul 12, 2018
@hjwilli
test updates
b7daa3d 
Updates so that all tests pass - lab test now just makes sure that a ml
algorithm starts running, doesn't check for success
Adding tests to check machine state against db state

References #40, References #52
hjwilli added a commit that referenced this issue Jul 12, 2018
@hjwilli
machine projects test updates
191b525 
working on test to compare machine server's project state to database
state

References #40, #52
hjwilli added a commit that referenced this issue Jul 12, 2018
@hjwilli
test updates
f5eba4f 
References #40, #52
hjwilli added a commit that referenced this issue Aug 1, 2018
@hjwilli
int test update
2248455 
Test updates, move runExperiments to a different test
References #40
hjwilli added a commit that referenced this issue Aug 1, 2018
@hjwilli
int test updates
8b7ec01 
References #40
hjwilli added a commit that referenced this issue Aug 2, 2018
@hjwilli
runExperiments breaks all proceeding tests
1938fa6 
References #40
@hjwilli
Copy link
Collaborator Author

hjwilli commented May 14, 2019

We've got tests!

@hjwilli hjwilli closed this as completed May 14, 2019
HyunjunA pushed a commit that referenced this issue Jul 28, 2023
@jay-m-dev
Merge pull request #40 from jay-m-dev/docker_optimize
a0e861c 
Docker optimize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjwilli hjwilli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjwilli @weixuanfu