This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
add support for targeting rule evaluation with semver #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vpai
force-pushed
the
varun/semver
branch
2 times, most recently
from
69de5ef to
1ec5d4e
Compare
vpai
force-pushed
the
varun/semver
branch
3 times, most recently
from
54a6d45 to
cac2b47
Compare
vpai
requested review from
leoromanovsky,
a team and
sameerank
and removed request for
a team
|
These Rubocop warnings are a lot. |
|
Closing in favor of #16. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Eppo's RAC API will start returning targeting rule values containing semver strings. Our SDKs need to be able to parse these strings and perform rule evaluation on them. This change in rule logic has already been applied to a few other SDKs:
Eppo-exp/python-sdk#27
Eppo-exp/js-sdk-common#38
Eppo-exp/eppo-ios-sdk#10
Description
The operations
lt,gt,lte,gteapply to both numeric values and semver strings. Previously it was only numeric values.Behavior of un-upgraded SDKs
They will continue to assume that only numeric values will be present for the
lt,gt,lte,gteoperations.