Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Samples unavailable on Mac Catalyst #539

Closed
wants to merge 31 commits into from
Closed

Conversation

dfeinzimer
Copy link
Contributor

Toolkit AR components are no longer available on Catalyst

@dfeinzimer dfeinzimer self-assigned this Nov 1, 2024
@yo1995 yo1995 changed the title Fix build [Fix] Samples unavailable on Mac Catalyst Nov 1, 2024
@dfeinzimer dfeinzimer marked this pull request as ready for review November 1, 2024 22:28
@dfeinzimer dfeinzimer requested a review from yo1995 November 1, 2024 22:28
@dfeinzimer
Copy link
Contributor Author

The offending PR has been reverted in the Toolkit for now.

@dfeinzimer dfeinzimer marked this pull request as draft November 1, 2024 23:38
@dfeinzimer
Copy link
Contributor Author

@yo1995 I've revised the changes a bit to generate a smaller SamplesApp+Samples.swift (preview).

Ready for review.

Shared/SamplesApp.swift Outdated Show resolved Hide resolved
@dfeinzimer dfeinzimer requested a review from yo1995 November 5, 2024 18:17
@yo1995 yo1995 changed the base branch from main to v.next November 5, 2024 18:49
@yo1995 yo1995 changed the base branch from v.next to main November 5, 2024 18:49
@yo1995
Copy link
Collaborator

yo1995 commented Nov 5, 2024

Hi David, did you branch off the main branch? I think this fix should go onto v.next. 🤔

@dfeinzimer dfeinzimer changed the base branch from main to v.next November 5, 2024 19:07
dfeinzimer and others added 2 commits November 5, 2024 11:13
Co-Authored-By: Ting <tchen@esri.com>
@dfeinzimer
Copy link
Contributor Author

Rebased to v.next and resolved merge conflicts, ready for re-review.

@dfeinzimer
Copy link
Contributor Author

Closing in favor of #541 at Ting's request

@dfeinzimer dfeinzimer closed this Nov 5, 2024
@dfeinzimer dfeinzimer deleted the df/buildFix branch November 5, 2024 19:39
@yo1995 yo1995 removed their request for review December 13, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants